Issue 563860043: weblinks: Fix encoding of link texts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 563860043: weblinks: Fix encoding of link texts (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years ago by hahnjo

Modified:
4 years ago

Reviewers:
hanwenn

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

weblinks: Fix encoding of link texts When switching to Python 3, I added the call of .encode('utf-8') to fix the build with Python 3.5. This converts all link texts into binary encoding, enclosed by b'...'. The correct fix is to force utf-8 encoding for sys.stdout. See e0c78a4c71 ("Use codecs.open() to decode as utf-8") for more details on this issue and how the default changes with Python 3.7.

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	scripts/build/create-weblinks-itexi.py	View		2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hahnjo

4 years ago (2020-04-12 13:22:44 UTC) #2

On 2020/04/12 12:36:22, hanwenn wrote:
> LGTM 
> 
> shortcut push? I can update the scripts afterwards.

commit 23dbc2090b1f45ae26c7f88af6945bde00cb2ddd
Author: Jonas Hahnfeld <hahnjo@hahnjo.de>
Date:   Sun Apr 12 14:11:37 2020 +0200

    weblinks: Fix encoding of link texts

in staging

Expand All Messages | Collapse All Messages