Issue 563630043: Add comments to code related to page breaking/layout

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 563630043: Add comments to code related to page breaking/layout (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 1 month ago by hanwenn

Modified:
4 years, 1 month ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Add comments to code related to page breaking/layout

Patch Set 1 #

Total comments: 7

Patch Set 2 : werner's comments #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -33 lines)			Patch
M	lily/include/page-breaking.hh	View	1	4 chunks	+14 lines, -3 lines	0 comments	Download
M	lily/include/page-spacing.hh	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	lily/page-breaking.cc	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	lily/page-spacing.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	lily/page-turn-page-breaking.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	lily/simple-spacer.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	lily/system.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	scm/clip-region.scm	View		3 chunks	+2 lines, -25 lines	0 comments	Download
M	scm/page.scm	View	1	5 chunks	+6 lines, -1 line	0 comments	Download
M	scm/paper-system.scm	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	scm/titling.scm	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

lemzwerg

LGTM. Please feel free to ignore (most of) my remarks if you consider such nitpicking ...

4 years, 1 month ago (2020-02-28 20:12:53 UTC) #1

hanwenn

4 years, 1 month ago (2020-03-15 15:34:25 UTC) #3

commit 0b9804f7ed4ac285a432c12b0dea5ab9c67a5eb0
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Fri Feb 28 14:01:38 2020 +0100

    Add comments to code related to page breaking/layout
    
    https://sourceforge.net/p/testlilyissues/issues/5802
    http://codereview.appspot.com/563630043

Expand All Messages | Collapse All Messages