Stops woodwind diagram info appearing on terminal

This patch has a couple of files from the LSR, which had minor changes from my last LSR patch.  I've included them to keep the system in step.  The main changes are to /snippets/new/woodwind-diagrams-key-lists.ly (and the associated changes to /snippets/woodwind-diagrams-key-lists.ly created with makelsr) and Documentation/notation/wind.itely.  I'd like someone with documentation experience to check this - I've taken out a lilipond example, because as written it runs and dumps key information to terminal when running make doc.  Just showing this as the code to be run prevents this.

[PhilEHolmes, 2012-02-06 12:35:57]

Please review - especially changes to Documentation/notation/wind.itely

[dak, 2012-02-06 13:28:24]

http://codereview.appspot.com/5636048/diff/1/Documentation/snippets/new/woodw...
File Documentation/snippets/new/woodwind-diagrams-key-lists.ly (right):

http://codereview.appspot.com/5636048/diff/1/Documentation/snippets/new/woodw...
Documentation/snippets/new/woodwind-diagrams-key-lists.ly:16:
#(print-keys-verbose 'piccolo (current-error-port))
This is ugly and tiresome to change.  Why don't you wrap the whole kaboodle in
#(with-output-to-port (current-error-port)
  (lambda ()
    (print-keys-verbose 'flute)
    (print-keys-verbose 'flute-b-extension)
...

I'd probably even do a for-each around the various instruments, but then the
snippet would not really look
all that instructive anymore.

[mail_philholmes.net, 2012-02-06 14:07:54]

----- Original Message ----- 
From: <dak@gnu.org>
To: <PhilEHolmes@googlemail.com>; <graham@percival-music.ca>; 
<tdanielsmusic@googlemail.com>; <pkx166h@gmail.com>
Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Monday, February 06, 2012 1:28 PM
Subject: Re: Stops woodwind diagram info appearing on terminal (issue 
5636048)


>
>
http://codereview.appspot.com/5636048/diff/1/Documentation/snippets/new/woodw...
> File Documentation/snippets/new/woodwind-diagrams-key-lists.ly (right):
>
>
http://codereview.appspot.com/5636048/diff/1/Documentation/snippets/new/woodw...
> Documentation/snippets/new/woodwind-diagrams-key-lists.ly:16:
> #(print-keys-verbose 'piccolo (current-error-port))
> This is ugly and tiresome to change.  Why don't you wrap the whole
> kaboodle in
> #(with-output-to-port (current-error-port)
>   (lambda ()
>     (print-keys-verbose 'flute)
>     (print-keys-verbose 'flute-b-extension)
> ...
>
> I'd probably even do a for-each around the various instruments, but then
> the snippet would not really look
> all that instructive anymore.
>
> http://codereview.appspot.com/5636048/


I didn't do that because I had no idea it would work.  As a snippet, I think 
it's easier to leave as is because the average user (e.g. me) would not 
understand the lambda stuff.

--
Phil Holmes

[dak, 2012-02-06 14:20:50]

On 2012/02/06 14:07:54, mail_philholmes.net wrote:

> I didn't do that because I had no idea it would work.  As a snippet, I think 
> it's easier to leave as is because the average user (e.g. me) would not 
> understand the lambda stuff.

Well, the thing is that you could also write
(with-output-to-file "this/file/name" (lambda () ...

And you can't do that all that nicely with an extra argument (well, you can open
a file port, use it, then close it again, but that is more cumbersome).