Fix auth and retries for batch.

[aiuto, 2012-02-08 20:43:54]

Mostly good. Just little nits.

http://codereview.appspot.com/5633052/diff/7/apiclient/http.py
File apiclient/http.py (right):

http://codereview.appspot.com/5633052/diff/7/apiclient/http.py#newcode532
apiclient/http.py:532: fp = StringIO.StringIO()
Is there a writeable buffer that 'yield's anything you put into it?  Then you
could flatten to that. It would avoid the double copy - but require a mass of
explanation.

http://codereview.appspot.com/5633052/diff/7/apiclient/http.py#newcode856
apiclient/http.py:856: class HttpMock(object):
Can this whole class move to a new file? It seems like it is only for tests.

http://codereview.appspot.com/5633052/diff/7/oauth2client/client.py
File oauth2client/client.py (right):

http://codereview.appspot.com/5633052/diff/7/oauth2client/client.py#newcode113
oauth2client/client.py:113: def refresh(self, http):
It might be easier to read if the order of authorize, refresh, apply were the
same in the abstract and derived classes.

http://codereview.appspot.com/5633052/diff/7/tests/test_oauth2client.py
File tests/test_oauth2client.py (right):

http://codereview.appspot.com/5633052/diff/7/tests/test_oauth2client.py#newco...
tests/test_oauth2client.py:72: self.assertEqual(content['Authorization'],
'Bearer 1/3w')
Should the order of params to all the assertEquals be changed to (expect, got)?

[jcgregorio_google, 2012-02-09 17:17:12]

http://codereview.appspot.com/5633052/diff/7/apiclient/http.py
File apiclient/http.py (right):

http://codereview.appspot.com/5633052/diff/7/apiclient/http.py#newcode532
apiclient/http.py:532: fp = StringIO.StringIO()
Yeah, would require a mass of explanation and probably not much of a savings
since this is for batch and should be used for a bunch of small requests.

On 2012/02/08 20:43:54, aiuto wrote:
> Is there a writeable buffer that 'yield's anything you put into it?  Then you
> could flatten to that. It would avoid the double copy - but require a mass of
> explanation.

http://codereview.appspot.com/5633052/diff/7/apiclient/http.py#newcode856
apiclient/http.py:856: class HttpMock(object):
Yes, but as a separate CL, as that will end up touching almost every test file.

Logged here so it doesn't get forgotten:
http://code.google.com/p/google-api-python-client/issues/detail?id=103

On 2012/02/08 20:43:54, aiuto wrote:
> Can this whole class move to a new file? It seems like it is only for tests.

http://codereview.appspot.com/5633052/diff/7/oauth2client/client.py
File oauth2client/client.py (right):

http://codereview.appspot.com/5633052/diff/7/oauth2client/client.py#newcode113
oauth2client/client.py:113: def refresh(self, http):
On 2012/02/08 20:43:54, aiuto wrote:
> It might be easier to read if the order of authorize, refresh, apply were the
> same in the abstract and derived classes.

Done.

http://codereview.appspot.com/5633052/diff/7/tests/test_oauth2client.py
File tests/test_oauth2client.py (right):

http://codereview.appspot.com/5633052/diff/7/tests/test_oauth2client.py#newco...
tests/test_oauth2client.py:72: self.assertEqual(content['Authorization'],
'Bearer 1/3w')
On 2012/02/08 20:43:54, aiuto wrote:
> Should the order of params to all the assertEquals be changed to (expect,
got)?

Done.

[aiuto, 2012-02-09 18:58:20]

lgtm

[jcgregorio_google, 2012-02-09 19:17:07]

On 2012/02/09 18:58:20, aiuto wrote:
> lgtm

Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=bb764d4ec44...