Build: website should rely on $LILYPOND_GIT

Build: website should rely on $LILYPOND_GIT

This work was sponsored by David Kastrup.

Doc: CG: explain website+LILYPOND_WEB_MEDIA_GIT

This work was sponsored by David Kastrup.


I'm pushing this to stable as soon as Patchy test-new has said
it's ok.  If anything needs fixing (other than a compile failure),
I'll do that in a later commit.

[Julien Rioux, 2012-02-04 23:10:50]

Curious about...

http://codereview.appspot.com/5630055/diff/2001/Documentation/contributor/web...
File Documentation/contributor/website-work.itexi (left):

http://codereview.appspot.com/5630055/diff/2001/Documentation/contributor/web...
Documentation/contributor/website-work.itexi:270: make -f website.make
WEBSITE_ONLY_BUILD=1 -B website
If we leave -B here, does it fix issue 2251?

[Graham Percival, 2012-02-04 23:33:35]

On Sat, Feb 04, 2012 at 11:10:51PM +0000, julien.rioux@gmail.com wrote:
> Documentation/contributor/website-work.itexi:270: make -f website.make
> WEBSITE_ONLY_BUILD=1 -B website
> If we leave -B here, does it fix issue 2251?

That's not the issue; once I'd boiled down the instructions and
tested them on my own computer, I noticed that cron was
complaining because LILYPOND_GIT wasn't set, because cron doesn't
inherit the normal user env vars.  :(

This is the second totally stupid mistake I've made recently
that's caused a lot of angst (the other was failing to properly
set up an independent user to run Patchy and thus having it use an
out-of-date lilypond git directory).  But they're both the kind of
thing that a second pair of eyes might have been able to catch in
about 5 minutes.

Moral of the story: we really need at least two people familiar
with, and ideally actively performing, all administrative tasks.
It's too easy for one person to have a little slip-up.

- Graham