Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12163)

Issue 562710043: add articulation support to multi measure rests

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by Malte Meyn
Modified:
4 years, 11 months ago
Reviewers:
dak, dan, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

add articulation support to multi measure rests This adds an event type MultiMeasureArticulationEvent and a grob type MultiMeasureRestScript and allows to add articulations/scripts to multi measure rests. This means that you can use \fermata now instead of \fermataMarkup. \fermataMarkup is deprecated, the regression tests are updated (convert-ly + manual changes in stencil-scale.ly and multi-measure-rest-text.ly).

Patch Set 1 #

Total comments: 4

Patch Set 2 : add documentation (Changes, NR, NR-de translated, NR-otherlanguages commented out), “multi measur… #

Patch Set 3 : use correct comment syntax #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -130 lines) Patch
M Documentation/ca/notation/expressive.itely View 1 2 3 chunks +8 lines, -3 lines 0 comments Download
M Documentation/ca/notation/rhythms.itely View 1 2 4 chunks +13 lines, -7 lines 0 comments Download
M Documentation/changes.tely View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Documentation/de/notation/expressive.itely View 1 2 chunks +5 lines, -8 lines 0 comments Download
M Documentation/de/notation/rhythms.itely View 1 3 chunks +15 lines, -14 lines 0 comments Download
M Documentation/es/notation/expressive.itely View 1 2 3 chunks +8 lines, -3 lines 0 comments Download
M Documentation/es/notation/rhythms.itely View 1 2 4 chunks +12 lines, -6 lines 0 comments Download
M Documentation/fr/notation/expressive.itely View 1 2 3 chunks +8 lines, -3 lines 0 comments Download
M Documentation/fr/notation/rhythms.itely View 1 2 4 chunks +13 lines, -6 lines 0 comments Download
M Documentation/it/notation/expressive.itely View 1 2 3 chunks +8 lines, -3 lines 0 comments Download
M Documentation/it/notation/rhythms.itely View 1 2 4 chunks +13 lines, -6 lines 0 comments Download
M Documentation/ja/notation/expressive.itely View 1 2 3 chunks +8 lines, -3 lines 0 comments Download
M Documentation/ja/notation/rhythms.itely View 1 2 4 chunks +13 lines, -7 lines 0 comments Download
M Documentation/notation/expressive.itely View 1 2 chunks +5 lines, -8 lines 0 comments Download
M Documentation/notation/rhythms.itely View 1 3 chunks +10 lines, -8 lines 0 comments Download
M input/regression/fermata-rest-position.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/full-measure-rest-fermata.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/morgenlied.ly View 2 chunks +2 lines, -3 lines 0 comments Download
M input/regression/multi-measure-rest-text.ly View 2 chunks +4 lines, -4 lines 1 comment Download
M input/regression/stencil-scale.ly View 2 chunks +4 lines, -4 lines 0 comments Download
M lily/multi-measure-rest-engraver.cc View 10 chunks +48 lines, -15 lines 0 comments Download
M ly/engraver-init.ly View 1 chunk +1 line, -0 lines 0 comments Download
M ly/property-init.ly View 1 2 2 chunks +1 line, -9 lines 0 comments Download
M python/convertrules.py View 2 chunks +2 lines, -0 lines 0 comments Download
M scm/define-event-classes.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 chunk +32 lines, -0 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 chunk +23 lines, -0 lines 0 comments Download
M scm/define-music-types.scm View 1 3 chunks +8 lines, -2 lines 0 comments Download
M scm/ly-syntax-constructors.scm View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8
lemzwerg
Without testing: LGTM, thanks! https://codereview.appspot.com/562710043/diff/582610043/input/regression/multi-measure-rest-text.ly File input/regression/multi-measure-rest-text.ly (right): https://codereview.appspot.com/562710043/diff/582610043/input/regression/multi-measure-rest-text.ly#newcode20 input/regression/multi-measure-rest-text.ly:20: R2.^\shortfermata Shouldn't this be rather ...
5 years ago (2019-04-19 15:34:25 UTC) #1
Malte Meyn
https://codereview.appspot.com/562710043/diff/582610043/input/regression/multi-measure-rest-text.ly File input/regression/multi-measure-rest-text.ly (right): https://codereview.appspot.com/562710043/diff/582610043/input/regression/multi-measure-rest-text.ly#newcode20 input/regression/multi-measure-rest-text.ly:20: R2.^\shortfermata On 2019/04/19 15:34:25, lemzwerg wrote: > Shouldn't this ...
5 years ago (2019-04-19 20:58:00 UTC) #2
Malte Meyn
add documentation (Changes, NR, NR-de translated, NR-otherlanguages commented out), “multi measure”→“multi-measure”
5 years ago (2019-04-20 15:52:33 UTC) #3
Malte Meyn
use correct comment syntax
4 years, 12 months ago (2019-04-21 20:26:25 UTC) #4
dak
Multimeasure rests can be split into multiple rests and across lines. That's what makes then ...
4 years, 11 months ago (2019-04-27 08:54:16 UTC) #5
dan_faithful.be
On Apr 27, 2019, at 04:54, dak@gnu.org wrote: > > Multimeasure rests can be split ...
4 years, 11 months ago (2019-04-27 11:27:44 UTC) #6
dak
Dan Eble <dan@faithful.be> writes: > On Apr 27, 2019, at 04:54, dak@gnu.org wrote: >> >> ...
4 years, 11 months ago (2019-04-27 11:31:24 UTC) #7
dan_faithful.be
4 years, 11 months ago (2019-04-27 19:48:18 UTC) #8
On Apr 27, 2019, at 07:31, David Kastrup <dak@gnu.org> wrote:
> 
> But we are talking about a \fermata on an _uncompressed_ multimeasure
> rest here.  If the compression leaves just a single rest, placing the
> fermata does not pose a conundrum to typesetting (it may pose one to the
> musician but that's entirely the composer's choice and fault).

I agree, though I won’t suggest that the issue should block acceptance of this
patch, since \fermataMarkup had the same problem.  Treating it as a known issue
would be nice.
— 
Dan

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b