Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(344)

Issue 5625053: Directs regtest output for last 2 files to stderr (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by PhilEHolmes
Modified:
12 years, 3 months ago
Reviewers:
Graham Percival, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

2 further regtests that send output to stdout as opposed to stderr. Updated to send the output to stderr. This is the last of this series of patches.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M input/regression/loglevels.ly View 1 chunk +11 lines, -11 lines 0 comments Download
M input/regression/scheme-engraver.ly View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2
PhilEHolmes
Please review.
12 years, 3 months ago (2012-02-04 16:39:00 UTC) #1
dak
12 years, 3 months ago (2012-02-04 16:46:12 UTC) #2
On 2012/02/04 16:39:00, PhilEHolmes wrote:
> Please review.

I am not actually sure that we should not for the regtests divert
current-output-port generally to current-error-port and be done without all
those fixups.  Of course, this will still need to cater for those parts of the
code that choose to go to stdout directly, bypassing Scheme.

Other than that general objection, looks like the way to go.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b