Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17328)

Issue 5625052: Directs lilypond option help to stderr (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by PhilEHolmes
Modified:
12 years, 2 months ago
Reviewers:
Graham Percival, dak, mail
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Now updated regtest to use David's optional argument.= to send output to stderr.

Patch Set 1 #

Patch Set 2 : Updated version to use David's updated program-option-scheme.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M input/regression/option-help.ly View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
PhilEHolmes
Please review minor change.
12 years, 2 months ago (2012-02-04 12:45:23 UTC) #1
dak
On 2012/02/04 12:45:23, PhilEHolmes wrote: > Please review minor change. If we have a Scheme ...
12 years, 2 months ago (2012-02-04 15:08:33 UTC) #2
dak
On 2012/02/04 15:08:33, dak wrote: > On 2012/02/04 12:45:23, PhilEHolmes wrote: > > Please review ...
12 years, 2 months ago (2012-02-04 15:45:21 UTC) #3
PhilEHolmes
See new description. Please review.
12 years, 2 months ago (2012-02-04 17:34:09 UTC) #4
dak
On 2012/02/04 17:34:09, PhilEHolmes wrote: > See new description. Please review. Well, "obviously" correct, but ...
12 years, 2 months ago (2012-02-04 17:40:18 UTC) #5
mail_philholmes.net
12 years, 2 months ago (2012-02-04 17:46:47 UTC) #6
----- Original Message ----- 
From: <dak@gnu.org>
To: <PhilEHolmes@googlemail.com>; <graham@percival-music.ca>
Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Saturday, February 04, 2012 5:40 PM
Subject: Re: Directs lilypond option help to stderr (issue 5625052)


> On 2012/02/04 17:34:09, PhilEHolmes wrote:
>> See new description.  Please review.
>
> Well, "obviously" correct, but it will still require one pass of the
> staging patchy before the testing patchy will be happy with it.  So
> depending on who runs which Patchy when, this might take some time to
> get the right blessings.
>
> http://codereview.appspot.com/5625052/


I ran staging patchy, co-incidentally a few minutes (I'd guess) after your 
update.  option-help now runs happily when compiled against fresh master.

--
Phil Holmes


Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b