On 2012/02/04 12:45:23, PhilEHolmes wrote: > Please review minor change. If we have a Scheme ...
12 years, 2 months ago
(2012-02-04 15:08:33 UTC)
#2
On 2012/02/04 12:45:23, PhilEHolmes wrote:
> Please review minor change.
If we have a Scheme function for printing, the output should not be hardwired to
a non-Scheme port, whether that be stderr or stdout. I think I mentioned as
much.
I'll push a reimplementation to staging in the next half hour because I don't
really have the time for all the red tape required to do everyone's bidding
properly.
On 2012/02/04 15:08:33, dak wrote: > On 2012/02/04 12:45:23, PhilEHolmes wrote: > > Please review ...
12 years, 2 months ago
(2012-02-04 15:45:21 UTC)
#3
On 2012/02/04 15:08:33, dak wrote:
> On 2012/02/04 12:45:23, PhilEHolmes wrote:
> > Please review minor change.
>
> If we have a Scheme function for printing, the output should not be hardwired
to
> a non-Scheme port, whether that be stderr or stdout. I think I mentioned as
> much.
>
> I'll push a reimplementation to staging in the next half hour because I don't
> really have the time for all the red tape required to do everyone's bidding
> properly.
Pushed as c20ff11378676b24f01be82f5cfbb022a0bfaab1 to staging. Please cater for
the remaining red tape (including using this arg in the regtest, finishing the
issues).
If you need similar functionality for stuff in main.cc (like ly:usage) please
take this as a model.
On 2012/02/04 17:34:09, PhilEHolmes wrote: > See new description. Please review. Well, "obviously" correct, but ...
12 years, 2 months ago
(2012-02-04 17:40:18 UTC)
#5
On 2012/02/04 17:34:09, PhilEHolmes wrote:
> See new description. Please review.
Well, "obviously" correct, but it will still require one pass of the staging
patchy before the testing patchy will be happy with it. So depending on who
runs which Patchy when, this might take some time to get the right blessings.
----- Original Message ----- From: <dak@gnu.org> To: <PhilEHolmes@googlemail.com>; <graham@percival-music.ca> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Saturday, February ...
12 years, 2 months ago
(2012-02-04 17:46:47 UTC)
#6
----- Original Message -----
From: <dak@gnu.org>
To: <PhilEHolmes@googlemail.com>; <graham@percival-music.ca>
Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Saturday, February 04, 2012 5:40 PM
Subject: Re: Directs lilypond option help to stderr (issue 5625052)
> On 2012/02/04 17:34:09, PhilEHolmes wrote:
>> See new description. Please review.
>
> Well, "obviously" correct, but it will still require one pass of the
> staging patchy before the testing patchy will be happy with it. So
> depending on who runs which Patchy when, this might take some time to
> get the right blessings.
>
> http://codereview.appspot.com/5625052/
I ran staging patchy, co-incidentally a few minutes (I'd guess) after your
update. option-help now runs happily when compiled against fresh master.
--
Phil Holmes
Issue 5625052: Directs lilypond option help to stderr
(Closed)
Created 12 years, 2 months ago by PhilEHolmes
Modified 12 years, 2 months ago
Reviewers: dak, Graham Percival, mail_philholmes.net
Base URL:
Comments: 0