Issue 5623051: Fix tuplet subdivision (issue 2243)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5623051: Fix tuplet subdivision (issue 2243) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Carl

Modified:
12 years, 2 months ago

Reviewers:
MikeSol

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix tuplet subdivision (issue 2243)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix documentation bug, subdivide only at tuplet + beat #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -15 lines)			Patch
A	input/regression/tuplet-subdivision.ly	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	lily/auto-beam-engraver.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	lily/beam-engraver.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	lily/beaming-pattern.cc	View	1	6 chunks	+22 lines, -8 lines	0 comments	Download
M	lily/include/beaming-pattern.hh	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	lily/stem.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	lily/stem-engraver.cc	View		5 chunks	+26 lines, -3 lines	0 comments	Download
M	scm/define-grob-properties.scm	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

MikeSol

12 years, 3 months ago (2012-02-03 07:01:13 UTC) #1

Haven't had a chance to test it, but the code looks good.

Have you tested this out yet with nested tuplets?

Cheers,
MS

http://codereview.appspot.com/5623051/diff/1/lily/beaming-pattern.cc
File lily/beaming-pattern.cc (right):

http://codereview.appspot.com/5623051/diff/1/lily/beaming-pattern.cc#newcode281
lily/beaming-pattern.cc:281: infos_[i].rhythmic_importance_ = -1;
Could you include a comment indicating what the numbers mean in rhythmic
importance?

Expand All Messages | Collapse All Messages