Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12618)

Issue 5623044: Doc: simplify example for unpure-pure containers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by Pavel Roskin
Modified:
12 years, 1 month ago
Reviewers:
Graham Percival, mike, dak, c_sorensen
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Doc: simplify example for unpure-pure containers Use of ly:event-property only confuses matters. Squares are never used. Draw circles unconditionally, make them empty inside (which would make the wrong output easier to discern) and name the macros roundNotes and smartRoundNotes. No need to define a separate Scheme function, a one-line lambda in stencil definition is enough. Don't remove Stem_engraver, just use whole notes and adjust the time signature.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M Documentation/notation/changing-defaults.itely View 1 chunk +11 lines, -17 lines 0 comments Download

Messages

Total messages: 8
Pavel Roskin
The example could be much simpler and still show the problem being addressed by the ...
12 years, 2 months ago (2012-02-02 19:32:50 UTC) #1
Graham Percival
LGTM, but I'd like David or Mike to give it the ok. If they do, ...
12 years, 2 months ago (2012-02-02 21:14:02 UTC) #2
Pavel Roskin
To be honest, there are many things I don't understand. In fact, I reduced the ...
12 years, 2 months ago (2012-02-03 15:38:16 UTC) #3
Pavel Roskin
Since nobody is interested, I'm closing this issue.
12 years, 1 month ago (2012-03-02 23:59:13 UTC) #4
dak
On 2012/02/03 15:38:16, Pavel Roskin wrote: > To be honest, there are many things I ...
12 years, 1 month ago (2012-03-03 05:37:40 UTC) #5
mike_apollinemike.com
On Feb 3, 2012, at 4:38 PM, plroskin@gmail.com wrote: > To be honest, there are ...
12 years, 1 month ago (2012-03-03 06:58:09 UTC) #6
c_sorensen
On 3/2/12 11:58 PM, "mike@apollinemike.com" <mike@apollinemike.com> wrote: >On Feb 3, 2012, at 4:38 PM, plroskin@gmail.com ...
12 years, 1 month ago (2012-03-03 14:33:27 UTC) #7
Pavel Roskin
12 years, 1 month ago (2012-03-03 17:19:41 UTC) #8
I mean, why is this needed?
\remove "Stem_engraver"
Stems must be fixing the problem somehow.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b