On 2012/02/02 19:14:57, Pavel Roskin wrote: > Too bad I only reviewed the "unpure-pure containers" ...
12 years, 2 months ago
(2012-02-02 19:19:48 UTC)
#2
On 2012/02/02 19:14:57, Pavel Roskin wrote:
> Too bad I only reviewed the "unpure-pure containers" documentation (issue
2040)
> after it was committed.
Pavel, I'm ok with the itely files, and I can see that the cc and scm files are
in comments only (I assume you are doing some kind of manual checking here), I
don't think we need to put this kind of typo patch on a countdown and we could
push this 'as is' once the checks were made. I'm happy if the devs don't mind
the scm and cc files being touched like this. I cannot speak for the
translations though.
james
LGTM*, please push immediately. * or rather: I dislike the US spelling of "canceled" vs. ...
12 years, 2 months ago
(2012-02-02 21:16:06 UTC)
#4
LGTM*, please push immediately.
* or rather: I dislike the US spelling of "canceled" vs. the proper British
spelling "cancelled", however our doc guide is quite clear: we use US spelling.
As such, the patch Looks Correct To Me, regardless of my personal feelings on
the matter. :)
Issue 5622049: Typo fixes
(Closed)
Created 12 years, 2 months ago by Pavel Roskin
Modified 12 years, 2 months ago
Reviewers: pkx166h, Graham Percival
Base URL: http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Comments: 0