Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15494)

Issue 5622049: Typo fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by Pavel Roskin
Modified:
12 years, 2 months ago
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Typo fixes Fix unneeded "ll" in "canceled", "canceling" and "labeled". Replace "and" with "an" in the documentation about unpure-pure containers.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M Documentation/contributor/issues.itexi View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/hu/learning/fundamental.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/learning/fundamental.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/music-glossary.tely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/nl/learning/fundamental.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/changing-defaults.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M input/regression/cue-clef.ly View 1 chunk +1 line, -1 line 0 comments Download
M lily/dynamic-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M scm/music-functions.scm View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
Pavel Roskin
Too bad I only reviewed the "unpure-pure containers" documentation (issue 2040) after it was committed.
12 years, 2 months ago (2012-02-02 19:14:57 UTC) #1
pkx166h
On 2012/02/02 19:14:57, Pavel Roskin wrote: > Too bad I only reviewed the "unpure-pure containers" ...
12 years, 2 months ago (2012-02-02 19:19:48 UTC) #2
Pavel Roskin
Just let me know which files should be left untouched and I'll submit the patch ...
12 years, 2 months ago (2012-02-02 19:36:37 UTC) #3
Graham Percival
12 years, 2 months ago (2012-02-02 21:16:06 UTC) #4
LGTM*, please push immediately.

* or rather: I dislike the US spelling of "canceled" vs. the proper British
spelling "cancelled", however our doc guide is quite clear: we use US spelling. 
As such, the patch Looks Correct To Me, regardless of my personal feelings on
the matter.  :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b