Issue 5620062: Dead code resection in SkDeferredCanvas

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5620062: Dead code resection in SkDeferredCanvas (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by junov1

Modified:
12 years, 10 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

closed with r3140

Patch Set 1 #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -9 lines)			Patch
	M	include/utils/SkDeferredCanvas.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	src/utils/SkDeferredCanvas.cpp	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

Is this required for correctness, or just a cleanup? i.e. if we roll M18 to ...

12 years, 10 months ago (2012-02-03 17:09:21 UTC) #2

junov1

12 years, 10 months ago (2012-02-03 18:25:49 UTC) #3

Just cleanup.

There is no problem whatsoever for rolling.  The method is not called from
webkit or chromium, and the virtual overload in ImageBufferSkia.cpp is not
declared with "overload", so this change and its webkit counterpart can be
rolled in any order without causing any trouble.

On 2012/02/03 17:09:21, reed1 wrote:
> Is this required for correctness, or just a cleanup? i.e. if we roll M18 to
> 2137, will we need to cherry-pick this into M18?
> 
> otherwise, LGTM

Expand All Messages | Collapse All Messages