Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5320)

Issue 561670043: Issue 5934: remove Repeated_music::folded_music_length (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by Dan Eble
Modified:
3 years, 11 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5934/ It looks like dead code.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M lily/include/repeated-music.hh View 2 chunks +1 line, -9 lines 0 comments Download
M lily/repeated-music.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 2
dak
Interesting. In 2.18 it appears to be used as length-callback in TremoloRepeatedMusic. Was that wrong ...
3 years, 11 months ago (2020-04-28 09:47:52 UTC) #1
dak
3 years, 11 months ago (2020-04-28 11:27:38 UTC) #2
dak@gnu.org writes:

> Interesting.  In 2.18 it appears to be used as length-callback in
> TremoloRepeatedMusic.  Was that wrong or did something change in
> unfolded_music_length ?
>
> https://codereview.appspot.com/561670043/

I need to focus on repo search techniques.  Issue 3745, apparently.
From 2013.  It's sobering that 2.18 does not yet contain it.

-- 
David Kastrup
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b