Issue 560840043: Fix relocate-preamble.py bug

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 560840043: Fix relocate-preamble.py bug

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 8 months ago by knupero

Modified:
4 years, 8 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Fix relocate-preamble.py bug In relocate-preamble.py the search path for python modules is changed. If a python script / module used in our regression tests is changed, the results of "make test-baseline", "make test" and patchy are random without this patch: Fresh scripts could load modules installed by an older version of lilypond.

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	python/relocate-preamble.py.in	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

knupero

Please review. See 'Re: Patchy email' thread in lilypond-devel. Knut

4 years, 8 months ago (2019-07-30 22:32:46 UTC) #1

LGTM, thanks!

Expand All Messages | Collapse All Messages