Issue 5608049: Add delete() to all Storages.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5608049: Add delete() to all Storages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by jcgregorio_google

Modified:
12 years, 7 months ago

Reviewers:
aiuto, jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Description

Fix for issue #45. http://code.google.com/p/google-api-python-client/issues/detail?id=45

Patch Set 3 : Address comments. #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -2 lines)			Patch
M	oauth2client/appengine.py	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	oauth2client/client.py	View	1 2	2 chunks	+22 lines, -0 lines	0 comments	Download
M	oauth2client/file.py	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	oauth2client/multistore_file.py	View	1	2 chunks	+28 lines, -0 lines	0 comments	Download
M	tests/test_oauth2client_appengine.py	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	tests/test_oauth2client_file.py	View		3 chunks	+26 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jcgregorio_google

Note that this doesn't add delete() for OAuth 1.0 Storages which will go away in ...

12 years, 7 months ago (2012-02-01 15:11:40 UTC) #1

aiuto

http://codereview.appspot.com/5608049/diff/8/oauth2client/appengine.py File oauth2client/appengine.py (right): http://codereview.appspot.com/5608049/diff/8/oauth2client/appengine.py#newcode272 oauth2client/appengine.py:272: credential = None Am i missing something? Does this ...

12 years, 7 months ago (2012-02-01 19:30:09 UTC) #2

jcgregorio_google

12 years, 7 months ago (2012-02-06 17:43:38 UTC) #3

jcgregorio_google

12 years, 7 months ago (2012-02-06 18:41:49 UTC) #5

On 2012/02/06 18:05:05, aiuto wrote:
> lgtm

Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=349862343cb...

Expand All Messages | Collapse All Messages