Issue 560790043: NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly (Closed)
|
Created:
5 years, 10 months ago by lilypond-pkx Modified:
5 years, 10 months ago CC:
lilypond-devel_gnu.org Visibility:
Public. |
DescriptionNR: 2.10 Arabic Music - inlcude references to hel-arabic.ly
Using information provided
by Hassan Elfatihi this
section now includes
references to the
significantly updated
hel-arabic.ly file.
Other fixes include making
sure we follow CG policy with
@seealso ordering as well
as line length and some
@notation{} syntax additions.
Patch Set 1 #
Total comments: 20
Patch Set 2 : Werner's corrections. #Patch Set 3 : With Hassan's correction. Thanks #MessagesTotal messages: 16
Some typographic issues. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... File Documentation/notation/world.itely (right): https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:185: The @code{hel-arabic.ly} file allows English note names to be used. Please use `@file' for file names. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:240: @ref{Common notation for non-Western music} I think there is a comma missing at the end of line. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:244: @file{ly/arabic.ly} Ditto. There are more such cases below. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:257: are defined in either @code{hel-arabic} or @file{arabic.ly} files and @file{hel-arabic.ly} ? https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:262: music. Arabic maqams only allow for limited modulations, due to the Please use two spaces after a full stop that ends a sentence. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:266: of music; Instead of a semicolon I think it's better to use either a full stop or a colon. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:281: below (e.g. @notation{bayati}, @notation{hussaini}, @notation{saba}, and e.g., https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:282: @notation{ushaq} can be indicated in the same way. These are all @notation{ushaq}) https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:290: parenthesis for those that are modulations of their base maqam. parentheses
Sign in to reply to this message.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... File Documentation/notation/world.itely (right): https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:185: The @code{hel-arabic.ly} file allows English note names to be used. On 2019/07/01 02:54:33, lemzwerg wrote: > Please use `@file' for file names.
Sign in to reply to this message.
Sign in to reply to this message.
Sign in to reply to this message.
NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly
Sign in to reply to this message.
Sign in to reply to this message.
On 2019/07/01 11:22:43, anthoneyhughes88 wrote:
Sign in to reply to this message.
Documentation/notation/world.itely https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... File Documentation/notation/world.itely (right): https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:185: The @code{hel-arabic.ly} file allows English note names to be used. On 2019/07/01 02:54:33, lemzwerg wrote: > Please use `@file' for file names. Done.
Sign in to reply to this message.
560790043
Sign in to reply to this message.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... File Documentation/notation/world.itely (right): https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:257: are defined in either @code{hel-arabic} or @file{arabic.ly} files and On 2019/07/01 02:54:33, lemzwerg wrote: > @file{hel-arabic.ly} ? Acknowledged. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:290: parenthesis for those that are modulations of their base maqam. On 2019/07/01 02:54:33, lemzwerg wrote: > parentheses Done.
Sign in to reply to this message.
Sign in to reply to this message.
Thanks Werner https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... File Documentation/notation/world.itely (right): https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:185: The @code{hel-arabic.ly} file allows English note names to be used. On 2019/07/01 02:54:33, lemzwerg wrote: > Please use `@file' for file names. Done. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:257: are defined in either @code{hel-arabic} or @file{arabic.ly} files and On 2019/07/01 02:54:33, lemzwerg wrote: > @file{hel-arabic.ly} ? Done. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:262: music. Arabic maqams only allow for limited modulations, due to the On 2019/07/01 02:54:33, lemzwerg wrote: > Please use two spaces after a full stop that ends a sentence. Done. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:266: of music; On 2019/07/01 02:54:33, lemzwerg wrote: > Instead of a semicolon I think it's better to use either a full stop or a colon. Done. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:281: below (e.g. @notation{bayati}, @notation{hussaini}, @notation{saba}, and On 2019/07/01 02:54:33, lemzwerg wrote: > e.g., Done. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:282: @notation{ushaq} can be indicated in the same way. These are all On 2019/07/01 02:54:33, lemzwerg wrote: > @notation{ushaq}) Done. https://codereview.appspot.com/560790043/diff/572830043/Documentation/notatio... Documentation/notation/world.itely:290: parenthesis for those that are modulations of their base maqam. On 2019/07/01 02:54:33, lemzwerg wrote: > parentheses Done.
Sign in to reply to this message.
Werner's corrections.
Sign in to reply to this message.
Hello everyone
About hel-arabic.ly
It seems to me that the example given is incomplete
You must write
\include "hel-arabic.ly"
\relative {
\key c \rast
c' d edb f | g a bdb c | c bb a g | f d c
}
Best regards
hassan el fatihi
Sign in to reply to this message.
With Hassan's correction. Thanks
Sign in to reply to this message.
~~~ NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly staging author Hassan Elfatihi <hassan.elfatihi@free.fr> Sun, 30 Jun 2019 10:49:45 +0100 (10:49 +0100) committer James Lowe <pkx166h@runbox.com> Sun, 14 Jul 2019 13:22:41 +0100 (13:22 +0100) commit c24f83991b772a65c15b6290cf70d725def117bd ~~~ Hassan did comment on the example used, but I will deal with that in a separate patch. Closing this one.
Sign in to reply to this message.
|
