Issue 5602045: [GPU]: Handle degenerate quads when computing UV matrix from control points

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5602045: [GPU]: Handle degenerate quads when computing UV matrix from control points (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by bsalomon

Modified:
12 years, 11 months ago

Reviewers:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : sdklfj #

Total comments: 1

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -4 lines)			Patch
	M	gm/convexpaths.cpp	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
	M	src/gpu/GrPathUtils.cpp	View	1 2	1 chunk	+40 lines, -4 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

TomH

12 years, 11 months ago (2012-01-31 20:24:55 UTC) #2

http://codereview.appspot.com/5602045/diff/2002/src/gpu/GrPathUtils.cpp
File src/gpu/GrPathUtils.cpp (right):

http://codereview.appspot.com/5602045/diff/2002/src/gpu/GrPathUtils.cpp#newco...
src/gpu/GrPathUtils.cpp:254: if (maxD > 0) {
Think about tolerance here; otherwise LGTM.

Expand All Messages | Collapse All Messages