Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)

Issue 5600044: Adding a flush method to SkCanvas (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by junov1
Modified:
12 years, 8 months ago
Reviewers:
bsalomon, reed1
CC:
Stephen White
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : added check for null device #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M gm/gmmain.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
junov1
This should help code clarity and brevity in webkit. There was already a private flush ...
12 years, 8 months ago (2012-01-30 14:25:14 UTC) #1
reed1
http://codereview.appspot.com/5600044/diff/1/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): http://codereview.appspot.com/5600044/diff/1/src/core/SkCanvas.cpp#newcode473 src/core/SkCanvas.cpp:473: void SkCanvas::flush() { Need to check for null device
12 years, 8 months ago (2012-01-30 14:35:05 UTC) #2
junov1
On 2012/01/30 14:35:05, reed1 wrote: > Need to check for null device Done.
12 years, 8 months ago (2012-01-30 14:39:29 UTC) #3
bsalomon
On 2012/01/30 14:39:29, junov1 wrote: > On 2012/01/30 14:35:05, reed1 wrote: > > Need to ...
12 years, 8 months ago (2012-01-30 14:45:04 UTC) #4
reed1
12 years, 8 months ago (2012-01-30 14:58:26 UTC) #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b