Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1733)

Issue 5599050: Add dithering to (32b?) radial gradients (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by TomH
Modified:
12 years, 10 months ago
Reviewers:
reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This is a dithering implementation for 32b. It creates LSB changes in: filltypespersp_8888 drawbitmaprect_8888 drawbitmaprect_gpu gradients_8888 clamped_gradients_8888 filltypespersp_4444 drawbitmaprect_565 shadertext_8888 clamped_gradients_4444 drawbitmaprect_4444 The new radial-gradient GMs look correctly dithered, but still display banding. There are no compile guards in here to protect old clients, but those can be added before commit if this implementation looks good.

Patch Set 1 #

Patch Set 2 : Merged radial dithers into same compile guard as linear dithers #

Patch Set 3 : Fix for vertically-striped dither in radial_completely_pinned #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M src/effects/SkGradientShader.cpp View 1 2 10 chunks +28 lines, -13 lines 0 comments Download

Messages

Total messages: 6
TomH
12 years, 10 months ago (2012-01-30 21:10:33 UTC) #1
reed1
lgtm
12 years, 10 months ago (2012-01-30 21:17:47 UTC) #2
TomH
This will require about 50 rebaselines in chromium. Also, it does not produce sufficient improvement ...
12 years, 10 months ago (2012-01-30 22:26:22 UTC) #3
TomH
To keep notes on gradient quality in one place: - 8b math appears to be ...
12 years, 10 months ago (2012-01-31 20:14:30 UTC) #4
TomH
This should be ready for commit (and GM rebaselining), but is parked while Mike addresses ...
12 years, 10 months ago (2012-02-01 22:02:10 UTC) #5
TomH
12 years, 10 months ago (2012-02-02 15:57:45 UTC) #6
Committed in r3126; will be rebaselined once some tool support is finished.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b