Issue 5599045: GRBK-321

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5599045: GRBK-321

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by tamsler

Modified:
13 years, 2 months ago

Reviewers:
constance.i.fuller, jpgorrono

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -1 line)			Patch
M	server/src/java/org/sakaiproject/gradebook/gwt/sakai/Gradebook2ComponentServiceImpl.java	View	2 chunks	+4 lines, -1 line	1 comment	Download
M	shared/src/java/org/sakaiproject/gradebook/gwt/client/I18nConstants.properties	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	shared/src/java/org/sakaiproject/gradebook/gwt/client/I18nConstants_es.properties	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

tamsler

http://codereview.appspot.com/5599045/diff/1/server/src/java/org/sakaiproject/gradebook/gwt/sakai/Gradebook2ComponentServiceImpl.java File server/src/java/org/sakaiproject/gradebook/gwt/sakai/Gradebook2ComponentServiceImpl.java (right): http://codereview.appspot.com/5599045/diff/1/server/src/java/org/sakaiproject/gradebook/gwt/sakai/Gradebook2ComponentServiceImpl.java#newcode6640 server/src/java/org/sakaiproject/gradebook/gwt/sakai/Gradebook2ComponentServiceImpl.java:6640: throw new InvalidInputException(i18n.getString("scoresEnteredNoGradeTypeChange", Please only use the single argument ...

13 years, 2 months ago (2012-01-30 18:44:58 UTC) #1

jpgorrono

13 years, 2 months ago (2012-01-30 19:14:08 UTC) #2

Sorry, but I don't see the value in conforming to a general lack of a default
values. But wouldn't object to you changing it.

On 2012/01/30 18:44:58, tamsler wrote:
>
http://codereview.appspot.com/5599045/diff/1/server/src/java/org/sakaiproject...
> File
>
server/src/java/org/sakaiproject/gradebook/gwt/sakai/Gradebook2ComponentServiceImpl.java
> (right):
> 
>
http://codereview.appspot.com/5599045/diff/1/server/src/java/org/sakaiproject...
>
server/src/java/org/sakaiproject/gradebook/gwt/sakai/Gradebook2ComponentServiceImpl.java:6640:
> throw new
InvalidInputException(i18n.getString("scoresEnteredNoGradeTypeChange",
> Please only use the single argument i18n.getString() method, so that we are
> consistent throughout the code base.
> 
> throw new InvalidInputException(i18n.getString("
>       scoresEnteredNoGradeTypeChange");

Expand All Messages | Collapse All Messages