Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1937)

Issue 5595043: Reimplement ChordRepetition facility. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by dak
Modified:
12 years, 2 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Remove basically all configurability. Reduce parser and lexer support to hardwired minimum. Don't track the last chord in the lexer/parser. Instead establish it at toplevel-music-functions level if the user has not already called \chordRepeats to do so himself. Addresses issue 1110 and my sense of aesthetics.

Patch Set 1 #

Patch Set 2 : Changes regtest/tabs to heed fingerings (may require another staging->master) #

Patch Set 3 : Some more polish, regtest changes. #

Patch Set 4 : Based on staging. Fix docs (not all related), add property doc. #

Patch Set 5 : A few typos in docs. Should be ready for patchy now. #

Patch Set 6 : Fix a timing problem reported by Werner, add regtest for it #

Patch Set 7 : Fix repeat tremolo on chord repetition. #

Total comments: 1

Patch Set 8 : Rearrange regtests. #

Patch Set 9 : Make the documentation illustrate the text contents better. #

Patch Set 10 : Incorporate DOC improvements from James with amendments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -275 lines) Patch
M Documentation/changes.tely View 1 2 3 4 3 chunks +15 lines, -6 lines 0 comments Download
M Documentation/notation/fretted-strings.itely View 1 2 3 4 3 chunks +19 lines, -15 lines 0 comments Download
M Documentation/notation/simultaneous.itely View 1 2 3 4 5 6 7 8 9 1 chunk +47 lines, -3 lines 0 comments Download
A input/regression/chord-repetition-times.ly View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
M input/regression/display-lily-tests.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/tablature-chord-repetition.ly View 1 2 3 4 5 6 7 1 chunk +4 lines, -2 lines 0 comments Download
A input/regression/tablature-chord-repetition-finger.ly View 1 2 3 4 5 6 7 1 chunk +28 lines, -0 lines 0 comments Download
M lily/include/lily-lexer.hh View 2 chunks +0 lines, -16 lines 0 comments Download
M lily/include/music-sequence.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/lexer.ll View 2 chunks +4 lines, -4 lines 0 comments Download
M lily/lily-lexer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M lily/lily-parser-scheme.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M lily/music-sequence.cc View 3 4 5 3 chunks +16 lines, -56 lines 0 comments Download
M lily/parser.yy View 1 2 2 chunks +1 line, -9 lines 0 comments Download
M ly/chord-repetition-init.ly View 1 2 1 chunk +37 lines, -75 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +0 lines, -8 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 2 3 4 5 2 chunks +38 lines, -35 lines 0 comments Download
M scm/define-music-types.scm View 2 chunks +1 line, -10 lines 0 comments Download
M scm/ly-syntax-constructors.scm View 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M scm/music-functions.scm View 1 2 3 4 5 6 4 chunks +67 lines, -2 lines 0 comments Download

Messages

Total messages: 1
dak
12 years, 2 months ago (2012-01-30 09:19:17 UTC) #1
http://codereview.appspot.com/5595043/diff/4020/input/regression/tablature-ch...
File input/regression/tablature-chord-repetition.ly (right):

http://codereview.appspot.com/5595043/diff/4020/input/regression/tablature-ch...
input/regression/tablature-chord-repetition.ly:5: to save the string
information. This setting is set as default with
Ok, I am not happy about this showing up as a change in regtests because, uh, it
is a changed regtest.

So I'll retain the old copy, mentioning that it uses a deprecated interface, and
create a new one under a different name that shows the new
functionality/interface.

Is that the way to do it?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b