DescriptionFix SyntaxWarning's
Individual changes:
1) abc2ly: Fix SyntaxWarning
This line still works in Python 3.8, but it throws a warning:
> SyntaxWarning: "is" with a literal. Did you mean "=="?
2) musicxml2ly: Remove drummode
This code is fundamentally broken: NoteEvent::ly_expression() and
NoteEvent::chord_element_ly() miss a '%' to format the string. Instead
the code "calls" the string which Python meets with a SyntaxWarning.
Trying to hit this code path, musicxml only sets the drum_type attribute
in Note::initialize_drum_event() called from Note::to_lily_object().
However as far as I understand the MusicXML specification, a <note>
must always have either a <pitch>, or <unpitched>, or <rest>.
If I try to construct an (invalid) input with only an instrument name,
musicxml2ly breaks at another function, so this is really dead code.
Patch Set 1 #Patch Set 2 : Drop drumtype_dict #
MessagesTotal messages: 3
|