Issue 5580048: GRBK-1099

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5580048: GRBK-1099

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by tamsler

Modified:
13 years, 1 month ago

Reviewers:
constance.i.fuller, jpgorrono

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -2 lines)			Patch
M	dev/src/java/log4j.properties	View	1 chunk	+1 line, -1 line	0 comments	Download
M	server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java	View	3 chunks	+7 lines, -0 lines	2 comments	Download
M	shared/src/java/org/sakaiproject/gradebook/gwt/client/I18nConstants.properties	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

tamsler

http://codereview.appspot.com/5580048/diff/1/server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java File server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java (right): http://codereview.appspot.com/5580048/diff/1/server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java#newcode64 server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java:64: import org.hibernate.mapping.Join; Please remove not needed import

13 years, 1 month ago (2012-01-30 18:50:56 UTC) #1

jpgorrono

13 years, 1 month ago (2012-01-30 19:18:47 UTC) #2

http://codereview.appspot.com/5580048/diff/1/server/src/java/org/sakaiproject...
File
server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java
(right):

http://codereview.appspot.com/5580048/diff/1/server/src/java/org/sakaiproject...
server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java:64:
import org.hibernate.mapping.Join;
On 2012/01/30 18:50:56, tamsler wrote:
> Please remove not needed import

Done.

Expand All Messages | Collapse All Messages