Issue 5577069: Reimplement ChordRepetition facility.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5577069: Reimplement ChordRepetition facility. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by dak

Modified:
12 years, 3 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Reimplement ChordRepetition facility. Remove basically all configurability. Reduce parser and lexer support to hardwired minimum. Don't track the last chord in the lexer/parser. Instead establish it at toplevel-music-functions level if the user has not already called \chordRepeats to do so himself. Addresses issue 1110 and my sense of aesthetics.

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+175 lines, -250 lines)			Patch
M	Documentation/changes.tely	View	1 chunk	+1 line, -1 line	0 comments	Download
M	input/regression/display-lily-tests.ly	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/include/lily-lexer.hh	View	2 chunks	+0 lines, -16 lines	0 comments	Download
M	lily/include/music-sequence.hh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/lexer.ll	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	lily/lily-lexer.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	lily/lily-parser-scheme.cc	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	lily/music-sequence.cc	View	3 chunks	+16 lines, -56 lines	0 comments	Download
M	lily/parser.yy	View	3 chunks	+8 lines, -11 lines	0 comments	Download
M	ly/chord-repetition-init.ly	View	1 chunk	+35 lines, -75 lines	0 comments	Download
M	ly/music-functions-init.ly	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	scm/define-music-display-methods.scm	View	2 chunks	+38 lines, -35 lines	0 comments	Download
M	scm/define-music-types.scm	View	2 chunks	+1 line, -10 lines	0 comments	Download
M	scm/ly-syntax-constructors.scm	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	scm/music-functions.scm	View	2 chunks	+66 lines, -0 lines	0 comments	Download