Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 5577068: code review 5577068: spec: emphasize that compilers may round or reject cons... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by remyoudompheng
Modified:
13 years, 10 months ago
Reviewers:
r, rsc, bsiegert, golang-dev
CC:
golang-dev, remy_archlinux.org
Visibility:
Public.

Description

spec: emphasize that compilers may round or reject constants. Fixes issue 2789.

Patch Set 1 #

Patch Set 2 : diff -r 8179934cf77e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8179934cf77e https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 8179934cf77e https://go.googlecode.com/hg/ #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M doc/go_spec.html View 1 2 3 2 chunks +6 lines, -1 line 4 comments Download

Messages

Total messages: 8
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 10 months ago (2012-01-28 11:18:06 UTC) #1
remyoudompheng
This proposal aims at clearly making issue 2789 a non-issue and explains why it is ...
13 years, 10 months ago (2012-01-28 11:20:21 UTC) #2
bsiegert
http://codereview.appspot.com/5577068/diff/3001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/5577068/diff/3001/doc/go_spec.html#newcode597 doc/go_spec.html:597: In particular, a compilar may refuse to handle integral ...
13 years, 10 months ago (2012-01-28 12:15:20 UTC) #3
remyoudompheng
Hello golang-dev@googlegroups.com, bsiegert@gmail.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), Please take another look.
13 years, 10 months ago (2012-01-28 13:04:53 UTC) #4
rsc
Please add Fixes issue 2789. to the CL description.
13 years, 10 months ago (2012-01-29 16:02:00 UTC) #5
r
i agree this should be settled but we need to define it better http://codereview.appspot.com/5577068/diff/5001/doc/go_spec.html File ...
13 years, 10 months ago (2012-01-29 16:07:15 UTC) #6
remyoudompheng
http://codereview.appspot.com/5577068/diff/5001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/5577068/diff/5001/doc/go_spec.html#newcode558 doc/go_spec.html:558: Precision of numeric constants may be subject to implementation ...
13 years, 10 months ago (2012-01-29 16:35:44 UTC) #7
remyoudompheng
13 years, 10 months ago (2012-02-10 07:45:36 UTC) #8
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b