Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(38)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
5574080
: JS: libphonenumber 4.5 (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by
tronikos
Modified:
13 years, 8 months ago
Reviewers:
Shaopeng
,
lararennie
,
shaopengjia
CC:
tronikos1
Base URL:
http://libphonenumber.googlecode.com/svn/trunk/
Visibility:
Public.
Patch Set 1
#
Created:
13 years, 10 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+1893 lines, -413 lines
)
Patch
javascript/README
View
2 chunks
+2 lines, -2 lines
0 comments
Download
javascript/i18n/phonenumbers/asyoutypeformatter.js
View
4 chunks
+9 lines, -5 lines
0 comments
Download
javascript/i18n/phonenumbers/asyoutypeformatter_test.js
View
3 chunks
+29 lines, -0 lines
0 comments
Download
javascript/i18n/phonenumbers/metadata.js
View
240 chunks
+499 lines, -132 lines
0 comments
Download
javascript/i18n/phonenumbers/metadatafortesting.js
View
18 chunks
+45 lines, -8 lines
0 comments
Download
javascript/i18n/phonenumbers/metadatalite.js
View
241 chunks
+498 lines, -131 lines
0 comments
Download
javascript/i18n/phonenumbers/phonemetadata.pb.js
View
2 chunks
+57 lines, -0 lines
0 comments
Download
javascript/i18n/phonenumbers/phonenumberutil.js
View
42 chunks
+438 lines, -100 lines
0 comments
Download
javascript/i18n/phonenumbers/phonenumberutil_test.js
View
33 chunks
+310 lines, -35 lines
0 comments
Download
javascript/i18n/phonenumbers/regioncodefortesting.js
View
1 chunk
+4 lines, -0 lines
0 comments
Download
tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataJsonFromXml.java
View
1 chunk
+2 lines, -0 lines
0 comments
Download
Messages
Total messages: 2
Expand All Messages
|
Collapse All Messages
tronikos
13 years, 10 months ago (2012-01-27 11:51:34 UTC)
#1
Sign in
to reply to this message.
Shaopeng
LGTM
13 years, 10 months ago (2012-01-27 12:30:01 UTC)
#2
LGTM
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 5574080: JS: libphonenumber 4.5 (Closed)
Created 13 years, 10 months ago by tronikos
Modified 13 years, 8 months ago
Reviewers: shaopengjia, lararennie, Shaopeng
Base URL: http://libphonenumber.googlecode.com/svn/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b