Issue 5572075: Fix the protocol for resumable uploads.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5572075: Fix the protocol for resumable uploads. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by jcgregorio_google

Modified:
12 years, 7 months ago

Reviewers:
aiuto

CC:
google-api-python-client_googlegroups.com, Ali Afshar

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Remove some dead code and comments. #

Patch Set 3 : Increase default upload size to 256K. #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -154 lines)			Patch
M	apiclient/discovery.py	View		3 chunks	+25 lines, -58 lines	0 comments	Download
M	apiclient/http.py	View	1 2	5 chunks	+12 lines, -33 lines	0 comments	Download
M	tests/test_discovery.py	View	1	4 chunks	+54 lines, -62 lines	0 comments	Download
M	tests/test_http.py	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

aiuto

lgtm Well that is simpler. Did the way discovery specifies it change?

12 years, 7 months ago (2012-01-27 21:48:27 UTC) #2

jcgregorio_google

12 years, 7 months ago (2012-01-27 22:02:29 UTC) #3

On Fri, Jan 27, 2012 at 4:48 PM,  <aiuto@google.com> wrote:
> lgtm
>
> Well that is simpler. Did the way discovery specifies it change?

No, just my understanding of it :)

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=5fcbf3a944a...

>
> http://codereview.appspot.com/5572075/

Expand All Messages | Collapse All Messages