Pass a typo correction callback object from ParseCastExpr to Sema::ActOnIdExpression to be a bit more selective about what kinds of corrections will be allowed for unknown identifiers.
Ping? I'd at least like someone more familiar with the parser to give this
patch a once-over before committing it.
Thanks,
Kaelyn
On Mon, Jan 23, 2012 at 12:45 PM, <rikka@google.com> wrote:
> Reviewers: kyrtzidis_apple.com,
>
> Description:
> Pass a typo correction callback object from ParseCastExpr to
> Sema::ActOnIdExpression to be a bit more selective about what kinds of
> corrections will be allowed for unknown identifiers.
>
> Please review this at
http://codereview.appspot.com/**5572049/<http://codereview.appspot.com/5572049/>
>
> Affected files:
> M include/clang/Parse/Parser.h
> M include/clang/Sema/Sema.h
> M lib/Parse/ParseExpr.cpp
> M lib/Parse/ParseExprCXX.cpp
> M lib/Sema/SemaExpr.cpp
> M test/SemaCXX/typo-correction.**cpp
>
>
>
LGTM!
On Jan 25, 2012, at 10:49 AM, Kaelyn Uhrain wrote:
> Ping? I'd at least like someone more familiar with the parser to give this
patch a once-over before committing it.
>
> Thanks,
> Kaelyn
>
> On Mon, Jan 23, 2012 at 12:45 PM, <rikka@google.com> wrote:
> Reviewers: kyrtzidis_apple.com,
>
> Description:
> Pass a typo correction callback object from ParseCastExpr to
> Sema::ActOnIdExpression to be a bit more selective about what kinds of
> corrections will be allowed for unknown identifiers.
>
> Please review this at http://codereview.appspot.com/5572049/
>
> Affected files:
> M include/clang/Parse/Parser.h
> M include/clang/Sema/Sema.h
> M lib/Parse/ParseExpr.cpp
> M lib/Parse/ParseExprCXX.cpp
> M lib/Sema/SemaExpr.cpp
> M test/SemaCXX/typo-correction.cpp
>
>
>
Issue 5572049: Avoid correcting unknown identifiers to types where types aren't allowed.
Created 14 years ago by Kaelyn
Modified 14 years ago
Reviewers: kyrtzidis_apple.com
Base URL:
Comments: 0