Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3837)

Issue 5571060: code review 5571060: doc/go1: mime, filepath.Walk (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by r
Modified:
12 years, 3 months ago
Reviewers:
CC:
golang-dev, gri, bradfitzgoog, adg
Visibility:
Public.

Description

doc/go1: mime, filepath.Walk

Patch Set 1 #

Total comments: 3

Patch Set 2 : diff -r 770d062819a9 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -2 lines) Patch
M doc/go1.html View 1 3 chunks +49 lines, -1 line 0 comments Download
M doc/go1.tmpl View 1 3 chunks +49 lines, -1 line 0 comments Download

Messages

Total messages: 5
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years, 3 months ago (2012-01-25 00:54:03 UTC) #1
gri
LGTM http://codereview.appspot.com/5571060/diff/1/doc/go1.tmpl File doc/go1.tmpl (right): http://codereview.appspot.com/5571060/diff/1/doc/go1.tmpl#newcode1161 doc/go1.tmpl:1161: The <code>WalkFunc</code> function will be called even for ...
12 years, 3 months ago (2012-01-25 00:56:53 UTC) #2
bradfitzgoog
LGTM but s/os.Error/error/ On Tue, Jan 24, 2012 at 4:54 PM, <r@golang.org> wrote: > Reviewers: ...
12 years, 3 months ago (2012-01-25 00:57:12 UTC) #3
adg
http://codereview.appspot.com/5571060/diff/1/doc/go1.html File doc/go1.html (right): http://codereview.appspot.com/5571060/diff/1/doc/go1.html#newcode1259 doc/go1.html:1259: in such casese the error value will describe the ...
12 years, 3 months ago (2012-01-25 00:58:06 UTC) #4
r
12 years, 3 months ago (2012-01-25 01:02:09 UTC) #5
*** Submitted as 5f4913cff1ef ***

doc/go1: mime, filepath.Walk

R=golang-dev, gri, bradfitz, adg
CC=golang-dev
http://codereview.appspot.com/5571060
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b