Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(947)

Issue 5569050: Doc: NR 5.5.5 Adv tweaks - Unpure-pure containers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by pkx166h
Modified:
12 years, 1 month ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR 5.5.5 Adv tweaks - Unpure-pure containers Tracker issue 2040 Added information about Unpure-pure containers based on information from Mike Solo

Patch Set 1 #

Total comments: 4

Patch Set 2 : 2nd patch after Mike's suggestions #

Total comments: 1

Patch Set 3 : fixed some Texinfo booboos - sorry Mr P. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -0 lines) Patch
M Documentation/notation/changing-defaults.itely View 1 2 2 chunks +103 lines, -0 lines 0 comments Download

Messages

Total messages: 6
MikeSol
Looks good! Much more user-understandable than anything I could have ever come up with :) ...
12 years, 2 months ago (2012-01-24 07:36:23 UTC) #1
pkx166h
http://codereview.appspot.com/5569050/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/5569050/diff/1/Documentation/notation/changing-defaults.itely#newcode3714 Documentation/notation/changing-defaults.itely:3714: evaluated correctly, usually returning a value of @var{0} or ...
12 years, 2 months ago (2012-01-24 07:47:13 UTC) #2
Graham Percival
very funny. http://codereview.appspot.com/5569050/diff/4001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/5569050/diff/4001/Documentation/notation/changing-defaults.itely#newcode3721 Documentation/notation/changing-defaults.itely:3721: this list as @q{pure}. The @q{pure} function ...
12 years, 2 months ago (2012-01-24 11:27:42 UTC) #3
Julien Rioux
On 2012/01/24 11:27:42, Graham Percival wrote: > If you actually ran "make" and it didn't ...
12 years, 2 months ago (2012-01-24 21:30:34 UTC) #4
Graham Percival
LGTM, although I don't understand any of the pure/unpure stuff.
12 years, 2 months ago (2012-01-30 12:10:02 UTC) #5
pkx166h
12 years, 1 month ago (2012-02-01 20:31:09 UTC) #6
committer	James Lowe <pkx166h@gmail.com>	

	 Wed, 1 Feb 2012 20:29:52 +0000 (20:29 +0000)

commit	1c8544f5052a64daf9c5895aff58c2d464fefd7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b