Issue 5558058: Skip subsurf normal allocation/calculation when not needed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5558058: Skip subsurf normal allocation/calculation when not needed (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by nicholasbishop

Modified:
13 years, 8 months ago

Reviewers:
brechtvl, bf-codereview

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

Description

CCGSubsurf has already a function to disable calculation of normals, but seems it wasn't used. This patch changes subsurf UV and subsurf_calculate_limit_positions() to not calculate normals, and also not allocate space for them. Should be no functional changes, just a small speedup/less memory use during subdivision for these cases.

Patch Set 1 #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -11 lines)			Patch
		source/blender/blenkernel/intern/subsurf_ccg.c	View		8 chunks	+15 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nicholasbishop

13 years, 9 months ago (2012-01-20 19:27:34 UTC) #3

On 2012/01/20 17:59:43, brechtvl wrote:
> LGTM.

Thanks, committed.

Expand All Messages | Collapse All Messages