Issue 5556059: Template instantiation of dependent attributes II

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by delesley

Modified:
13 years ago

Reviewers:
chandlerc

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 4

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+338 lines, -18 lines)			Patch
M	include/clang/Basic/Attr.td	View	4 chunks	+15 lines, -0 lines	0 comments	Download
M	include/clang/CMakeLists.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/clang/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
A	include/clang/Sema/CMakeLists.txt	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	include/clang/Sema/Makefile	View	1 chunk	+14 lines, -0 lines	4 comments	Download
M	lib/Sema/CMakeLists.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/Sema/SemaDecl.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/Sema/SemaDeclAttr.cpp	View	1 chunk	+5 lines, -7 lines	0 comments	Download
M	lib/Sema/SemaTemplateInstantiateDecl.cpp	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	test/SemaCXX/warn-thread-safety-analysis.cpp	View	3 chunks	+127 lines, -3 lines	0 comments	Download
M	utils/TableGen/ClangAttrEmitter.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	utils/TableGen/ClangAttrEmitter.cpp	View	12 chunks	+141 lines, -3 lines	0 comments	Download
M	utils/TableGen/TableGen.cpp	View	3 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

chandlerc

Tiny, horribly nit-picky whitespace comments. =D The build changes look fine. http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile File include/clang/Sema/Makefile (right): ...

13 years ago (2012-01-20 19:45:22 UTC) #1

delesley

I don't mind nitpicky comments, so long as an LGTM comes at the end. :-) ...

13 years ago (2012-01-20 22:14:19 UTC) #2

delesley

13 years ago (2012-01-20 22:15:08 UTC) #3

I don't mind nitpicky comments, so long as an LGTM comes at the end.  :-)

http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile
File include/clang/Sema/Makefile (right):

http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile#newc...
include/clang/Sema/Makefile:10: $(CLANG_TBLGEN) $(ObjDir)/.dir
On 2012/01/20 19:45:22, chandlerc wrote:
> Despite the failure to do this in the file you likely based this off of, I'd
> appreciate it if you line the first $ here with the $ after the : above.

Done.

http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile#newc...
include/clang/Sema/Makefile:13: $(call SYSPATH, $@) -I $(PROJ_SRC_DIR)/../../ $<
On 2012/01/20 19:45:22, chandlerc wrote:
> And I think this is more commonly 1 tabe and 2 spaces indent. Yea, I know, I'm
> the most nitpicky person ever... sorry...

Done.

Expand All Messages | Collapse All Messages