Issue 5556054: Fix issue 2228: Add option for strictBeatBeaming

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5556054: Fix issue 2228: Add option for strictBeatBeaming (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Carl

Modified:
12 years, 3 months ago

Reviewers:
pkx166h, janek

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix issue 2228: Add option for strictBeatBeaming This reverts to the default behavior from 2.14 that places a higher priority on avoiding beamlets than on beaming to the beat. At the user's option, beaming can be strictly to the beat.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Properly add strict-beat-beaming.ly #

Total comments: 2

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -10 lines)			Patch
M	Documentation/notation/rhythms.itely	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	Documentation/snippets/new/strict-beat-beaming.ly	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
A	Documentation/snippets/strict-beat-beaming.ly	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
M	input/regression/beamlet-point-toward-beat.ly	View		1 chunk	+9 lines, -6 lines	1 comment	Download
M	lily/beaming-pattern.cc	View		5 chunks	+15 lines, -4 lines	0 comments	Download
M	lily/include/beaming-pattern.hh	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	scm/define-context-properties.scm	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

pkx166h

Just a minor nitpick. http://codereview.appspot.com/5556054/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5556054/diff/1/Documentation/notation/rhythms.itely#newcode2192 Documentation/notation/rhythms.itely:2192: @cindex beamlets, orienting @cindex beamlets, ...

12 years, 3 months ago (2012-01-19 09:22:45 UTC) #1

janek

12 years, 3 months ago (2012-01-22 17:16:23 UTC) #2

LGTM.  I'm not sure if the word "flags" should be used here.

http://codereview.appspot.com/5556054/diff/2001/input/regression/beamlet-poin...
File input/regression/beamlet-point-toward-beat.ly (right):

http://codereview.appspot.com/5556054/diff/2001/input/regression/beamlet-poin...
input/regression/beamlet-point-toward-beat.ly:6: belong.  The first beam avoids
sticking out flags (the default);
"sticking out beamlets" i think?

http://codereview.appspot.com/5556054/diff/2001/scm/define-context-properties...
File scm/define-context-properties.scm (right):

http://codereview.appspot.com/5556054/diff/2001/scm/define-context-properties...
scm/define-context-properties.scm:480: beat structure even if it causes flags to
hang out?")
"even if it causes flags"
...beamlets?

Expand All Messages | Collapse All Messages