Makes sure dynamics don't budge for tuplet brackets.

Makes sure dynamics don't budge for tuplet brackets.

[Carl, 2012-01-18 18:35:34]

LGTM

[Keith, 2012-01-19 02:27:36]

LGTM

If you run it through fixcc.py we won't get the trailing whitespace warning.

http://codereview.appspot.com/5555046/diff/1/lily/tuplet-bracket.cc
File lily/tuplet-bracket.cc (right):

http://codereview.appspot.com/5555046/diff/1/lily/tuplet-bracket.cc#newcode660
lily/tuplet-bracket.cc:660: {
blanks

http://codereview.appspot.com/5555046/diff/1/lily/tuplet-bracket.cc#newcode668
lily/tuplet-bracket.cc:668: 
blanks

[janek, 2012-01-21 22:02:10]

So the problem was that by default tupletBracket doesn't have
outside-staff-priority (because we want it to be placed on staff lines
sometimes), and the code failed to check for that?

But i don't see how this patch solved the same problem with
outside-staff-priority set to something:

 { % this produced wrong output in 2.15.26, but now is ok:
   \override TupletBracket #'outside-staff-priority = #3
   \times 2/3 {c''4\ff c'' c''}
 }

could you explain?

[mike_apollinemike.com, 2012-01-21 22:06:05]

On Jan 21, 2012, at 11:02 PM, janek.lilypond@gmail.com wrote:

> So the problem was that by default tupletBracket doesn't have
> outside-staff-priority (because we want it to be placed on staff lines
> sometimes), and the code failed to check for that?
> 
> But i don't see how this patch solved the same problem with
> outside-staff-priority set to something:
> 
> { % this produced wrong output in 2.15.26, but now is ok:
>   \override TupletBracket #'outside-staff-priority = #3
>   \times 2/3 {c''4\ff c'' c''}
> }
> 
> could you explain?
> 

The idea is that if outside-staff-priority is set for either the tuplet-bracket
or the dynamics, their vertical spacing with respect to each other should be out
of the hands of tuplet-bracket.cc and in the hands of the
axis-group-interface.cc .

Cheers,
MS

[janek, 2012-01-22 00:41:09]

2012/1/21 mike@apollinemike.com <mike@apollinemike.com>:
> On Jan 21, 2012, at 11:02 PM, janek.lilypond@gmail.com wrote:
>> { % this produced wrong output in 2.15.26, but now is ok:
>>   \override TupletBracket #'outside-staff-priority = #3
>>   \times 2/3 {c''4\ff c'' c''}
>> }
>
> The idea is that if outside-staff-priority is set for either the
tuplet-bracket or the dynamics, their vertical spacing with respect to each
other should be out of the hands of tuplet-bracket.cc and in the hands of the
axis-group-interface.cc .

Sounds nice, but i don't see how it actually happens.  There's nothing
like "axis-group-interface" in the code that follows :(

thanks,
Janek