Issue 5554043: Build: Strict error checking from makeinfo and texi2html (issue 2219).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5554043: Build: Strict error checking from makeinfo and texi2html (issue 2219). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Julien Rioux

Modified:
12 years, 2 months ago

Reviewers:
mail

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Build: Strict error checking from makeinfo and texi2html (issue 2219). Run makeinfo and texi2html with --error-limit=0.

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	make/doc-i18n-root-vars.make	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	stepmake/stepmake/texinfo-vars.make	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mail_philholmes.net

----- Original Message ----- From: <julien.rioux@gmail.com> To: <julien.rioux@gmail.com> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Tuesday, January 17, ...

12 years, 3 months ago (2012-01-18 09:07:44 UTC) #2

----- Original Message ----- 
From: <julien.rioux@gmail.com>
To: <julien.rioux@gmail.com>
Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Tuesday, January 17, 2012 11:13 PM
Subject: Build: Strict error checking from makeinfo and texi2html 
(issue2219). (issue 5554043)


> Reviewers: ,
>
> Description:
> Build: Strict error checking from makeinfo and texi2html (issue 2219).
>
> Run makeinfo and texi2html with --error-limit=0.
>
> Please review this at http://codereview.appspot.com/5554043/
>
> Affected files:
>   M make/doc-i18n-root-vars.make
>   M stepmake/stepmake/texinfo-vars.make
>
>
> Index: make/doc-i18n-root-vars.make
> diff --git a/make/doc-i18n-root-vars.make b/make/doc-i18n-root-vars.make
> index 
>
8c20f494bde0106e624edd30e2a9c140267dcd84..654969ea9536b3fdcc29b53da983026a56eef7fa

> 100644
> --- a/make/doc-i18n-root-vars.make
> +++ b/make/doc-i18n-root-vars.make
> @@ -31,7 +31,7 @@ DOCUMENTATION_INCLUDES = \
>    -I $(top-build-dir)/Documentation/$(outdir)
>
>  LILYPOND_BOOK_INCLUDES += $(DOCUMENTATION_INCLUDES)
> -MAKEINFO_FLAGS += --force --enable-encoding $(DOCUMENTATION_INCLUDES)
> +MAKEINFO_FLAGS += --enable-encoding $(DOCUMENTATION_INCLUDES)
>  MAKEINFO = LANG= $(MAKEINFO_PROGRAM) $(MAKEINFO_FLAGS)
>
>  # texi2html xref map files
> Index: stepmake/stepmake/texinfo-vars.make
> diff --git a/stepmake/stepmake/texinfo-vars.make 
> b/stepmake/stepmake/texinfo-vars.make
> index 
>
2f2d801ab1210e1bc784306df498c5e84d5b553f..d16e7d63a3319d4f9587a149c0e83f5287a3f1c2

> 100644
> --- a/stepmake/stepmake/texinfo-vars.make
> +++ b/stepmake/stepmake/texinfo-vars.make
> @@ -33,7 +33,7 @@ TEXINFO_PAPERSIZE_OPTION= $(if $(findstring 
> $(PAPERSIZE),a4),,-t @afourpaper)
>
>  DOCUMENTATION_INCLUDES += -I $(top-src-dir)/Documentation
>
> -MAKEINFO_FLAGS += --enable-encoding $(DOCUMENTATION_INCLUDES)
> +MAKEINFO_FLAGS += --enable-encoding --error-limit=0 
> $(DOCUMENTATION_INCLUDES)
>  MAKEINFO = LANG= $(MAKEINFO_PROGRAM) $(MAKEINFO_FLAGS)
>
>  # texi2html xref map files
> @@ -53,7 +53,7 @@ TEXI2HTML_INIT 
>   --init-file=$(top-src-dir)/Documentation/lilypond-texi2html.ini
>  TEXI2HTML_SPLIT = --prefix=index --split=section
>
>  TEXI2HTML_INCLUDES += --I=$(src-dir) --I=$(outdir) 
> $(DOCUMENTATION_INCLUDES) --I=$(XREF_MAPS_DIR)
> -TEXI2HTML_FLAGS += $(TEXI2HTML_INCLUDES) $(TEXI2HTML_INIT) 
> $(TEXI2HTML_LANG)
> +TEXI2HTML_FLAGS += --error-limit=0 $(TEXI2HTML_INCLUDES) 
> $(TEXI2HTML_INIT)  $(TEXI2HTML_LANG)
>  TEXI2HTML = TOP_SRC_DIR=$(top-src-dir) PERL_UNICODE=SD 
> $(TEXI2HTML_PROGRAM)
>  ###########


Have you run make doc with these changes?

--
Phil Holmes

Julien Rioux

12 years, 3 months ago (2012-01-18 13:46:39 UTC) #3

> Have you run make doc with these changes?
> 
> --
> Phil Holmes
> 
> 

I did but forgot make check, so that will delay the review some more until
errors are fixed there.

Thanks,
Julien

Expand All Messages | Collapse All Messages