Issue 5553051: Fallout from GrDrawState::reset()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5553051: Fallout from GrDrawState::reset() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by bsalomon

Modified:
12 years, 11 months ago

Reviewers:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -10 lines)			Patch
M	src/gpu/GrContext.cpp	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/gpu/GrDrawState.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/gpu/GrDrawTarget.h	View		3 chunks	+10 lines, -5 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 3

bsalomon

Two improvements found when investigating perf drop after GrDrawState::reset() 1. That change disabled clipping when ...

12 years, 11 months ago (2012-01-18 19:34:53 UTC) #1

TomH

Per discussion, some asserts might be safe to remove? LGTM.

12 years, 11 months ago (2012-01-18 19:48:11 UTC) #2

bsalomon

12 years, 11 months ago (2012-01-18 19:52:34 UTC) #3

On 2012/01/18 19:48:11, TomH wrote:
> Per discussion, some asserts might be safe to remove?
> LGTM.

Checked in at r3067 with asserts removed.