Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1753)

Issue 555300043: Express define-markup-list-command-internal using define-markup-command-internal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by hanwenn
Modified:
4 years, 1 month ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Express define-markup-list-command-internal using define-markup-command-internal

Patch Set 1 #

Patch Set 2 : update call-site in parser.yy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -24 lines) Patch
M lily/parser.yy View 1 1 chunk +1 line, -1 line 0 comments Download
M scm/markup-macros.scm View 2 chunks +14 lines, -23 lines 0 comments Download

Messages

Total messages: 3
thomasmorley651
Not tested, but from reading: very nice. LGTM
4 years, 1 month ago (2020-02-16 14:19:33 UTC) #1
hanwenn
update call-site in parser.yy
4 years, 1 month ago (2020-02-16 17:51:25 UTC) #2
hanwenn
4 years, 1 month ago (2020-02-21 15:23:30 UTC) #3
commit 9f1683921621b612b94080d506ee317b058b29c8 
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Sat Feb 15 12:36:32 2020 +0100

    Express define-markup-list-command-internal using
define-markup-command-internal
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b