Issue 555260044: Fix convert-ly with Python 3

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 555260044: Fix convert-ly with Python 3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 2 months ago by hahnjo

Modified:
4 years, 2 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Fix convert-ly with Python 3 The error was "'str' object has no attribute 'decode'", so it already is decoded. The encoding seems to also be correct, as filenames with Unicode characters work just fine. It's worrying that none of the usual testing commands seem to invoke the script with a real input file, only the output of --help is used. --- If possible I'd like to push this as soon as possible. The normal process fails on convert-ly anyhow...

Patch Set 1 #

Total comments: 2

Patch Set 2 : Drop line #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	scripts/convert-ly.py	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

hahnjo

On 2020/02/04 19:32:10, dak wrote: > Foreseeable consequences for Python 2.7? None, because the minimum ...

4 years, 2 months ago (2020-02-04 19:40:41 UTC) #2

dak

https://codereview.appspot.com/555260044/diff/567150044/scripts/convert-ly.py File scripts/convert-ly.py (right): https://codereview.appspot.com/555260044/diff/567150044/scripts/convert-ly.py#newcode361 scripts/convert-ly.py:361: f = f That line looks spurious. Any reason ...

4 years, 2 months ago (2020-02-04 19:45:34 UTC) #3

hahnjo

4 years, 2 months ago (2020-02-04 19:50:23 UTC) #5

https://codereview.appspot.com/555260044/diff/567150044/scripts/convert-ly.py
File scripts/convert-ly.py (right):

https://codereview.appspot.com/555260044/diff/567150044/scripts/convert-ly.py...
scripts/convert-ly.py:361: f = f
On 2020/02/04 19:45:33, dak wrote:
> That line looks spurious.  Any reason for keeping it in?

Hm, no :D

Expand All Messages | Collapse All Messages