LGTM On Sat, Jan 14, 2012 at 11:36 AM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
12 years, 3 months ago
(2012-01-14 19:47:16 UTC)
#2
LGTM
On Sat, Jan 14, 2012 at 11:36 AM, <r@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> go/doc: print only one newline between paragraphs
> Fixes issue 2595.
>
> Please review this at http://codereview.appspot.com/5544068/
>
> Affected files:
> M src/pkg/go/doc/comment.go
>
>
> Index: src/pkg/go/doc/comment.go
> ===================================================================
> --- a/src/pkg/go/doc/comment.go
> +++ b/src/pkg/go/doc/comment.go
> @@ -353,12 +353,10 @@
> width: width,
> indent: indent,
> }
> - for i, b := range blocks(text) {
> + for _, b := range blocks(text) {
> switch b.op {
> case opPara:
> - if i > 0 {
> - w.Write(nl)
> - }
> + // l.write will add leading newline if required
> for _, line := range b.lines {
> l.write(line)
> }
>
>
*** Submitted as 5081ac4f9d04 *** go/doc: print only one newline between paragraphs Fixes issue 2595. ...
12 years, 3 months ago
(2012-01-14 19:57:37 UTC)
#3
*** Submitted as 5081ac4f9d04 ***
go/doc: print only one newline between paragraphs
Fixes issue 2595.
R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5544068
Issue 5544068: code review 5544068: go/doc: print only one newline between paragraphs
(Closed)
Created 12 years, 3 months ago by r
Modified 12 years, 3 months ago
Reviewers:
Base URL:
Comments: 0