Issue 5544052: Modify SkBitmap::extractSubset() to respect volatility

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5544052: Modify SkBitmap::extractSubset() to respect volatility (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by skyostil

Modified:
12 years, 11 months ago

Reviewers:
junov, bsalomon, junov1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Modify SkBitmap::extractSubset() to respect volatility The resulting subset bitmap will always have the same volatility flag as the source bitmap. BUG=452 Committed: http://code.google.com/p/skia/source/detail?r=3039

Patch Set 1 #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	src/core/SkBitmap.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	tests/BitmapCopyTest.cpp	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

LGTM. junov@ do you think this is the right thing to do (propagate volatile in ...

12 years, 11 months ago (2012-01-13 18:40:49 UTC) #3

junov1

12 years, 11 months ago (2012-01-13 20:20:54 UTC) #4

On 2012/01/13 18:40:49, bsalomon wrote:
> LGTM. junov@ do you think this is the right thing to do (propagate volatile in
> extractSubset)?

For now, this is good. 

Something I was discussing with Mike a few days ago is that it would be nice to
get rid the possibility of having pixels without a pixel ref.  That way, flags
like this one would not have to be propagated, we'd just store it in SkPixelRef.
 But that is for another day.

LGTM

Expand All Messages | Collapse All Messages