Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1219)

Issue 5544052: Modify SkBitmap::extractSubset() to respect volatility (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by skyostil
Modified:
12 years, 9 months ago
Reviewers:
junov, bsalomon, junov1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Modify SkBitmap::extractSubset() to respect volatility The resulting subset bitmap will always have the same volatility flag as the source bitmap. BUG=452 Committed: http://code.google.com/p/skia/source/detail?r=3039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/core/SkBitmap.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/BitmapCopyTest.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
skyostil
12 years, 10 months ago (2012-01-13 16:50:15 UTC) #1
TomH
(Driveby) LGTM
12 years, 10 months ago (2012-01-13 18:40:28 UTC) #2
bsalomon
LGTM. junov@ do you think this is the right thing to do (propagate volatile in ...
12 years, 10 months ago (2012-01-13 18:40:49 UTC) #3
junov1
12 years, 10 months ago (2012-01-13 20:20:54 UTC) #4
On 2012/01/13 18:40:49, bsalomon wrote:
> LGTM. junov@ do you think this is the right thing to do (propagate volatile in
> extractSubset)?

For now, this is good. 

Something I was discussing with Mike a few days ago is that it would be nice to
get rid the possibility of having pixels without a pixel ref.  That way, flags
like this one would not have to be propagated, we'd just store it in SkPixelRef.
 But that is for another day.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b