Issue 5543070: AddressSanitizer: return False for __asan_get_ownership(NULL)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5543070: AddressSanitizer: return False for __asan_get_ownership(NULL) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by samsonov

Modified:
12 years, 10 months ago

Reviewers:
ramosian.glider, glider, kcc

CC:
llvm-commits_cs.uiuc.edu

Base URL:
https://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/asan/

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 2

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -29 lines)			Patch
M	asan_allocator.cc	View	3 chunks	+9 lines, -25 lines	2 comments	Download
M	asan_interface.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/asan_interface_test.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

glider

LGTM otherwise http://codereview.appspot.com/5543070/diff/1/asan_allocator.cc File asan_allocator.cc (right): http://codereview.appspot.com/5543070/diff/1/asan_allocator.cc#newcode829 asan_allocator.cc:829: return malloc_info.AllocationSize((uintptr_t)ptr); Can you please explicitly check ...

12 years, 10 months ago (2012-01-17 14:40:07 UTC) #2

samsonov

12 years, 10 months ago (2012-01-18 15:30:58 UTC) #3

r148394

http://codereview.appspot.com/5543070/diff/1/asan_allocator.cc
File asan_allocator.cc (right):

http://codereview.appspot.com/5543070/diff/1/asan_allocator.cc#newcode829
asan_allocator.cc:829: return malloc_info.AllocationSize((uintptr_t)ptr);
On 2012/01/17 14:40:07, glider wrote:
> Can you please explicitly check for non-NULL in AllocationSize? That will save
> us a couple of cycles.

Done (instead, treat NULL as a special case in AllocationSize).

Expand All Messages | Collapse All Messages