Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(621)

Issue 5543052: add constant coverage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by bsalomon
Modified:
12 years, 9 months ago
Reviewers:
TomH
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Patch Set 4 : update #

Patch Set 5 : rebaseline with GrDrawState::reset checked in #

Patch Set 6 : remove premultiplied color asserts unrelated to the rest of the change #

Patch Set 7 : remove premultiplied color asserts unrelated to the rest of the change #

Patch Set 8 : cleanup #

Total comments: 2

Patch Set 9 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -76 lines) Patch
M src/gpu/GrDrawState.h View 1 2 3 4 5 6 7 8 4 chunks +32 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -3 lines 0 comments Download
M src/gpu/GrGLProgram.h View 1 2 3 4 5 6 7 8 4 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/GrGLProgram.cpp View 1 2 3 4 5 6 7 8 11 chunks +106 lines, -57 lines 0 comments Download
M src/gpu/GrGpuGLShaders.h View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/GrGpuGLShaders.cpp View 1 2 3 4 5 6 7 8 9 chunks +75 lines, -10 lines 0 comments Download

Messages

Total messages: 2
bsalomon
Today we have two ways of specifying colors to a GrDrawTarget draw: 1. Set constant ...
12 years, 9 months ago (2012-01-17 17:01:25 UTC) #1
TomH
12 years, 9 months ago (2012-01-17 19:36:05 UTC) #2
Minor bug? Fix that and LGTM.

http://codereview.appspot.com/5543052/diff/1010/src/gpu/GrDrawState.h
File src/gpu/GrDrawState.h (right):

http://codereview.appspot.com/5543052/diff/1010/src/gpu/GrDrawState.h#newcode134
src/gpu/GrDrawState.h:134: * to 1 (0xff). This value is ignored when there is
per-vertex coverage.
BUG: Default value mentioned in comments but not actually provided in function
declaration?

http://codereview.appspot.com/5543052/diff/1010/src/gpu/GrDrawState.h#newcode143
src/gpu/GrDrawState.h:143: */
If uint8_t version has a default value, should this one as well? (I don't
*think* so, but want to make sure, given apparent accidental omission above)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b