Issue 5540063: fix the following warning

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5540063: fix the following warning (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by guanqun

Modified:
12 years, 10 months ago

Reviewers:
epoger, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

fix the following warning ../samplecode/SampleTextOnPath.cpp:120:64: warning: passing NULL to non-pointer argument 4 of ‘SkScalar SkPaint::measureText(const void*, size_t, SkRect*, SkScalar) const’ [-Wconversion-null] BUG= TEST=

Patch Set 1 #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	samplecode/SampleTextOnPath.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

epoger

On 2012/01/17 14:13:30, reed1 wrote: > lgtm LGTM. Let me know if you need me ...

12 years, 11 months ago (2012-01-17 14:35:00 UTC) #3

guanqun

On 2012/01/17 14:35:00, epoger wrote: > LGTM. Let me know if you need me to ...

12 years, 11 months ago (2012-01-18 00:30:54 UTC) #4

epoger

12 years, 11 months ago (2012-01-18 17:02:45 UTC) #5

landed as http://code.google.com/p/skia/source/detail?r=3060

Expand All Messages | Collapse All Messages