Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11836)

Issue 553930044: Issue 5919 Make InstrumentName.X-offset more robust (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by thomasmorley651
Modified:
3 years, 12 months ago
Reviewers:
Dan Eble, dan
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5919 Make InstrumentName.X-offset more robust Currently system-start-text::calc-y-offset takes right end of system-start-grobs into account, which may lead to bad results, if one of them is omitted (collapse-height) or moved to the right. Instead we always use the value of indent for the right end and calculate the left end similar as before.

Patch Set 1 #

Patch Set 2 : Dan's advice, adds regtest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -10 lines) Patch
A input/regression/instrument-name-system-start-delimiter.ly View 1 1 chunk +32 lines, -0 lines 0 comments Download
M scm/output-lib.scm View 1 chunk +9 lines, -10 lines 0 comments Download

Messages

Total messages: 4
thomasmorley651
4 years ago (2020-04-18 18:14:33 UTC) #1
Dan Eble
On 2020/04/18 18:14:33, thomasmorley651 wrote: I ran make check and didn't see any differences. Without ...
4 years ago (2020-04-18 18:38:31 UTC) #2
dan_faithful.be
On Apr 18, 2020, at 14:38, nine.fierce.ballads@gmail.com wrote: > > On 2020/04/18 18:14:33, thomasmorley651 wrote: ...
4 years ago (2020-04-18 18:50:29 UTC) #3
thomasmorley651
4 years ago (2020-04-18 20:03:01 UTC) #4
Dan's advice, adds regtest
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b