Issue 553490051: lilypond-book: Remove custom package loading

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 553490051: lilypond-book: Remove custom package loading (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 2 months ago by hahnjo

Modified:
4 years, 2 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

lilypond-book: Remove custom package loading AFAICT this feature is not documented and only used for the musicxml testsuite. However the output of the formatter in the loaded module book-musicxml-testsuite.py only differs by whitespace from the default. (This also gets rid of the deprecation warning for module 'imp'.)

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -81 lines)			Patch
M	input/regression/musicxml/GNUmakefile	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	input/regression/musicxml/book-musicxml-testsuite.py	View	1 chunk	+0 lines, -64 lines	0 comments	Download
M	scripts/lilypond-book.py	View	3 chunks	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hahnjo

If we want to retain this functionality, I will implement this via importlib.util.spec_from_file_location() + importlib.util.module_from_spec(). ...

4 years, 2 months ago (2020-02-01 12:01:33 UTC) #1

LGTM

Expand All Messages | Collapse All Messages