Allocate D3D queries from a pool for the Display.

Allocate D3D queries from a pool for the Display.

This is a workaround for an Intel bug.

The crash looks like this:

0x5f816c53	 [d3d9.dll	 + 0x00036c53]	CQuery::~CQuery()
0x5f816bec	 [d3d9.dll	 + 0x00036bec]	CQuery::`vector deleting
destructor'(unsigned int)
0x5f7e8129	 [d3d9.dll	 + 0x00008129]	CBaseObject::~CBaseObject()
0x5f9e19c7	 [libglesv2.dll	 + 0x000319c7]	gl::Fence::`vector deleting
destructor'(unsigned int)
0x5f9de78e	 [libglesv2.dll	 - context.cpp:975]	gl::Context::deleteFence(unsigned
int)
0x5f9e1491	 [libglesv2.dll	 - context.cpp:198]	gl::Context::~Context()
0x5f9e182f	 [libglesv2.dll	 - context.cpp:3936]	glDestroyContext
0x717654ec	 [libegl.dll	 -
display.cpp:749]	egl::Display::destroyContext(gl::Context *)
0x7176a3da	 [libegl.dll	 - libegl.cpp:907]	eglDestroyContext
0x64fbaf33	 [chrome.dll	 - gl_context_egl.cc:75]	gfx::GLContextEGL::Destroy()

The vendor ID is always 8086 (Intel). Not an XP issue - it's happening on Win
7.

With this change, D3D queries are only released when the display is destroyed or reset or if a very high number of D3D queries have been allocated.

Tested by stepping exercising the NV_fence entry points in a debugger.
Committed: http://code.google.com/p/angleproject/source/detail?r=941

[apatrick1, 2012-01-10 23:12:28]

This should fix the last of the Intel D3D query related crashes.

Thanks,

Al

[dgkoch, 2012-01-11 13:45:51]

http://codereview.appspot.com/5534065/diff/1/src/libEGL/Display.cpp
File src/libEGL/Display.cpp (right):

http://codereview.appspot.com/5534065/diff/1/src/libEGL/Display.cpp#newcode1098
src/libEGL/Display.cpp:1098: freeEventQuery(query);
you need to avoid the free if  query is NULL

http://codereview.appspot.com/5534065/diff/1/src/libEGL/Display.h
File src/libEGL/Display.h (right):

http://codereview.appspot.com/5534065/diff/1/src/libEGL/Display.h#newcode110
src/libEGL/Display.h:110: std::vector<IDirect3DQuery9*> mEventQueryPool;
you might want to include a comment that this is a pool of *currently unused*
queries

http://codereview.appspot.com/5534065/diff/1/src/libGLESv2/Fence.cpp
File src/libGLESv2/Fence.cpp (right):

http://codereview.appspot.com/5534065/diff/1/src/libGLESv2/Fence.cpp#newcode40
src/libGLESv2/Fence.cpp:40: egl::Display *display = getDisplay();
this getDisplay() is redundant here

[apatrick1, 2012-01-11 19:01:07]

Thanks! All done.

[dgkoch, 2012-01-11 19:05:06]

LGTM