Don't handle Http404 as real exceptions.

To reproduce this locally set settings.DEBUG=False and open http://localhost:8080/foo.

As far as I can tell Http404 is the only exception that is defined by Django i n this context and that is already treated specially by Django itself (see https://docs.djangoproject.com/en/1.3/topics/http/views/#the-http404-exception).

[gvrpython, 2012-01-22 16:38:25]

LGTM

On Sun, Jan 22, 2012 at 1:35 AM,  <albrecht.andi@googlemail.com> wrote:
> Reviewers: M-A, GvR, techtonik,
>
> Description:
> To reproduce this locally set settings.DEBUG=False and open
> http://localhost:8080/foo.
>
> As far as I can tell Http404 is the only exception that is defined by
> Django i n this context and that is already treated specially by Django
> itself (see
>
https://docs.djangoproject.com/en/1.3/topics/http/views/#the-http404-exception).
>
> Please review this at http://codereview.appspot.com/5532116/
>
> Affected files:
>  M codereview/middleware.py
>
>
> Index: codereview/middleware.py
> ===================================================================
> --- a/codereview/middleware.py
> +++ b/codereview/middleware.py
> @@ -21,7 +21,7 @@
>  from google.appengine.runtime import DeadlineExceededError
>
>  from django.conf import settings
> -from django.http import HttpResponse
> +from django.http import Http404, HttpResponse
>  from django.template import Context, loader
>
>  from codereview import models
> @@ -57,7 +57,7 @@
>
>
>   def process_exception(self, request, exception):
> -    if settings.DEBUG:
> +    if settings.DEBUG or isinstance(exception, Http404):
>       return None
>     if isinstance(exception, apiproxy_errors.CapabilityDisabledError):
>       msg = ('Rietveld: App Engine is undergoing maintenance. '
>
>



-- 
--Guido van Rossum (python.org/~guido)

[Andi Albrecht, 2012-01-22 17:22:03]

Thanks, committed and live.

@Guido: Do you still need versions 79-84? I've had a "too many versions" error
on upload :)

[gvrpython, 2012-01-23 02:11:22]

Go ahead and delete those versions!

On Sun, Jan 22, 2012 at 9:22 AM,  <albrecht.andi@googlemail.com> wrote:
> Thanks, committed and live.
>
> @Guido: Do you still need versions 79-84? I've had a "too many versions"
> error on upload :)
>
> http://codereview.appspot.com/5532116/



-- 
--Guido van Rossum (python.org/~guido)