Issue 5531064: Make schema handle defaults that are strings.

Issue 5531064: Make schema handle defaults that are strings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by jcgregorio_google

Modified:
13 years, 6 months ago

Reviewers:
aiuto

CC:
google-api-python-client_googlegroups.com, darist

Visibility:
Public.

Description

Also fixes the order of simplejson import attempts. Fixes issue http://code.google.com/p/google-api-python-client/issues/detail?id=85

Patch Set 2 : Use anyjson.py in oauth2client #

Patch Set 3 : Move to one anyjson.py in oauth2client. #

Patch Set 5 : Move all dependencies to oauth2client.anyjson #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -145 lines)			Patch
M	Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	apiclient/anyjson.py	View	1 2	1 chunk	+0 lines, -32 lines	0 comments	Download
M	apiclient/discovery.py	View	1 2 3 4	2 chunks	+1 line, -1 line	0 comments	Download
M	apiclient/errors.py	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	apiclient/http.py	View	1 2 3 4	2 chunks	+1 line, -1 line	0 comments	Download
M	apiclient/model.py	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	apiclient/oauth.py	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	apiclient/schema.py	View	1 2 3 4	2 chunks	+6 lines, -6 lines	0 comments	Download
A	oauth2client/anyjson.py	View	1 2 3	1 chunk	+32 lines, -0 lines	0 comments	Download
M	oauth2client/appengine.py	View	1	1 chunk	+1 line, -10 lines	0 comments	Download
M	oauth2client/client.py	View	1	2 chunks	+1 line, -10 lines	0 comments	Download
M	oauth2client/clientsecrets.py	View	1	1 chunk	+1 line, -9 lines	0 comments	Download
M	oauth2client/crypt.py	View	1	1 chunk	+1 line, -10 lines	0 comments	Download
M	oauth2client/file.py	View	1	1 chunk	+1 line, -12 lines	0 comments	Download
M	oauth2client/multistore_file.py	View	1	1 chunk	+1 line, -10 lines	0 comments	Download
M	tests/test_json_model.py	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/test_oauth2client.py	View	1 2 3 4	1 chunk	+1 line, -10 lines	0 comments	Download
M	tests/test_oauth2client_appengine.py	View	1 2 3 4	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/test_oauth2client_file.py	View	1 2 3 4	1 chunk	+3 lines, -14 lines	0 comments	Download
M	tests/test_oauth2client_jwt.py	View	1 2 3 4	1 chunk	+2 lines, -11 lines	0 comments	Download
M	tests/test_schema.py	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

aiuto

http://codereview.appspot.com/5531064/diff/1/tests/test_oauth2client.py File tests/test_oauth2client.py (right): http://codereview.appspot.com/5531064/diff/1/tests/test_oauth2client.py#newcode36 tests/test_oauth2client.py:36: try: # pragma: no cover If you have anyjson.py, ...

13 years, 6 months ago (2012-01-11 04:41:10 UTC) #2

jcgregorio_google

13 years, 6 months ago (2012-01-11 14:51:02 UTC) #3

jcgregorio_google

13 years, 6 months ago (2012-01-11 16:26:34 UTC) #5

On 2012/01/11 15:29:56, aiuto wrote:
> lgtm

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=7e8efcb89fc...

Expand All Messages | Collapse All Messages