Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(802)

Issue 5531045: code review 5531045: atomicops: Alpha doesn't have a read memory barrier in... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by Stefano Rivera
Modified:
11 years, 10 months ago
Reviewers:
CC:
rsc, re2-dev_googlegroups.com
Visibility:
Public.

Description

atomicops: Alpha doesn't have a read memory barrier instruction, we use "mb" Fixes issue 56.

Patch Set 1 #

Patch Set 2 : diff -r d49d9934b9aa https://re2.googlecode.com/hg #

Patch Set 3 : diff -r d49d9934b9aa https://re2.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M util/atomicops.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Stefano Rivera
Hello rsc@golang.org (cc: re2-dev@googlegroups.com), I'd like you to review this change to https://re2.googlecode.com/hg
12 years, 2 months ago (2012-01-07 16:30:00 UTC) #1
rsc
LGTM Thank you!
12 years, 2 months ago (2012-01-26 17:33:04 UTC) #2
rsc
12 years, 2 months ago (2012-01-26 17:33:20 UTC) #3
*** Submitted as http://code.google.com/p/re2/source/detail?r=8ae0ce71e7a1 ***

atomicops: fix build on Alpha

Fixes issue 56.

R=rsc
CC=re2-dev
http://codereview.appspot.com/5531045

Committer: Russ Cox <rsc@swtch.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b