Issue 5530069: Use forward slashes as path separators in latex (issue 2209).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5530069: Use forward slashes as path separators in latex (issue 2209). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Julien Rioux

Modified:
12 years, 3 months ago

Reviewers:
Graham Percival

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Use forward slashes as path separators in latex (issue 2209).

Patch Set 1 #

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	python/book_latex.py	View		2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Graham Percival

http://codereview.appspot.com/5530069/diff/1/python/book_latex.py File python/book_latex.py (right): http://codereview.appspot.com/5530069/diff/1/python/book_latex.py#newcode274 python/book_latex.py:274: rep['base'] = basename.replace ('\\', '/') hmm, isn't there anything ...

12 years, 3 months ago (2012-01-11 04:42:43 UTC) #2

Julien Rioux

12 years, 3 months ago (2012-01-11 13:56:34 UTC) #3

On Tue, Jan 10, 2012 at 11:42 PM,  <graham@percival-music.ca> wrote:
>
> http://codereview.appspot.com/5530069/diff/1/python/book_latex.py
> File python/book_latex.py (right):
>
> http://codereview.appspot.com/5530069/diff/1/python/book_latex.py#newcode274
> python/book_latex.py:274: rep['base'] = basename.replace ('\\', '/')
> hmm, isn't there anything in os.path that could handle this
> automagically for us?  I get nervous when I see explicit '/' in path
> names in python.
>
> http://codereview.appspot.com/5530069/

Here rep is a dictionary used for string replacement in the output,
and I only modify it for latex output, so I think it's pretty safe. We
could add checks for os.path.sep == '\\' and os.path.altsep == '/',
but otherwise I don't know of any os.path functions to replace path
separators.

Expand All Messages | Collapse All Messages